Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cadence 1.0] Improve Migration #5479

Merged
merged 52 commits into from
Mar 11, 2024

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Feb 28, 2024

Improve the migration in several ways. See individual commits.

Also contains #5499, so can be ignored

@turbolent turbolent requested review from a team February 28, 2024 23:10
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 54.09982% with 515 lines in your changes are missing coverage. Please review.

Project coverage is 55.95%. Comparing base (752788a) to head (afeb436).

Files Patch % Lines
cmd/util/ledger/migrations/cadence_value_diff.go 48.36% 262 Missing and 22 partials ⚠️
cmd/util/ledger/migrations/prune_migration.go 0.00% 63 Missing ⚠️
...til/ledger/migrations/account_storage_migration.go 0.00% 45 Missing ⚠️
...util/ledger/migrations/cadence_values_migration.go 64.54% 28 Missing and 11 partials ⚠️
...execution-state-extract/execution_state_extract.go 73.63% 27 Missing and 2 partials ⚠️
cmd/util/ledger/migrations/merge.go 28.00% 16 Missing and 2 partials ⚠️
cmd/util/cmd/execution-state-extract/cmd.go 66.66% 10 Missing and 3 partials ⚠️
cmd/util/ledger/migrations/cadence.go 86.74% 10 Missing and 1 partial ⚠️
...md/util/ledger/migrations/transaction_migration.go 75.67% 6 Missing and 3 partials ⚠️
fvm/systemcontracts/system_contracts.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           feature/stable-cadence    #5479      +/-   ##
==========================================================
- Coverage                   56.00%   55.95%   -0.06%     
==========================================================
  Files                        1042     1045       +3     
  Lines                      102010   102968     +958     
==========================================================
+ Hits                        57134    57612     +478     
- Misses                      40526    40963     +437     
- Partials                     4350     4393      +43     
Flag Coverage Δ
unittests 55.95% <54.09%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@turbolent turbolent mentioned this pull request Feb 29, 2024
@turbolent
Copy link
Member Author

@janezpodhostnik Added suggestion for #5484, #5484 (comment), in 1a966ce

@turbolent turbolent changed the base branch from feature/stable-cadence to auto-update-onflow-cadence-v1.0.0-preview.10 March 8, 2024 20:15
@turbolent turbolent marked this pull request as ready for review March 8, 2024 20:15
@turbolent turbolent requested a review from ramtinms as a code owner March 8, 2024 20:15
@turbolent turbolent requested a review from a team March 8, 2024 20:16
Base automatically changed from auto-update-onflow-cadence-v1.0.0-preview.10 to feature/stable-cadence March 8, 2024 20:34
Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly focused the cadence migrations related changes. LGTM!

@turbolent turbolent merged commit 2fad084 into feature/stable-cadence Mar 11, 2024
51 checks passed
@turbolent turbolent deleted the bastian/improve-migration-2 branch March 11, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants