Iniitial geoparquet support #1839
msbarrysonar.yml
on: pull_request
Analyze with Sonar
5m 22s
Annotations
7 warnings
|
MINOR CODE_SMELL:
planetiler-core/src/main/java/com/onthegomap/planetiler/Planetiler.java#L498
Remove useless curly braces around statement
rule: java:S1602 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS1602&rule_key=java%3AS1602)
issue url: https://sonarcloud.io/project/issues?pullRequest=888&open=AY-SazMs_nuKm1h1lzJj&id=onthegomap_planetiler
|
|
MAJOR CODE_SMELL:
planetiler-core/src/main/java/com/onthegomap/planetiler/reader/parquet/GeoArrow.java#L22
Add a private constructor to hide the implicit public one.
rule: java:S1118 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS1118&rule_key=java%3AS1118)
issue url: https://sonarcloud.io/project/issues?pullRequest=888&open=AY-Qs7FvkqPXZmbpdEWT&id=onthegomap_planetiler
|
|
CRITICAL CODE_SMELL:
planetiler-core/src/main/java/com/onthegomap/planetiler/reader/parquet/MapRecordMaterializer.java#L348
Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation.
rule: java:S1186 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS1186&rule_key=java%3AS1186)
issue url: https://sonarcloud.io/project/issues?pullRequest=888&open=AY-Qs7F1kqPXZmbpdEWU&id=onthegomap_planetiler
|
|
CRITICAL CODE_SMELL:
planetiler-core/src/main/java/org/apache/hadoop/io/compress/Lz4Codec.java#L8
Rename this class.
rule: java:S2176 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS2176&rule_key=java%3AS2176)
issue url: https://sonarcloud.io/project/issues?pullRequest=888&open=AY-Qs7F3kqPXZmbpdEWV&id=onthegomap_planetiler
|
|
MAJOR CODE_SMELL:
planetiler-core/src/main/java/org/apache/parquet/filter2/predicate/Filters.java#L10
Add a private constructor to hide the implicit public one.
rule: java:S1118 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS1118&rule_key=java%3AS1118)
issue url: https://sonarcloud.io/project/issues?pullRequest=888&open=AY-Qs7F5kqPXZmbpdEWW&id=onthegomap_planetiler
|
|
MAJOR CODE_SMELL:
planetiler-core/src/test/java/com/onthegomap/planetiler/reader/parquet/ParquetInputFileTest.java#L92
Refactor this method to reduce the number of assertions from 31 to less than 25.
rule: java:S5961 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS5961&rule_key=java%3AS5961)
issue url: https://sonarcloud.io/project/issues?pullRequest=888&open=AY-Qs7EbkqPXZmbpdEWS&id=onthegomap_planetiler
|
|
MINOR CODE_SMELL:
planetiler-examples/src/main/java/com/onthegomap/planetiler/examples/overture/OvertureBasemap.java#L19
Replace this "switch" statement by "if" statements to increase readability.
rule: java:S1301 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS1301&rule_key=java%3AS1301)
issue url: https://sonarcloud.io/project/issues?pullRequest=888&open=AY-Qs7F8kqPXZmbpdEWX&id=onthegomap_planetiler
|