-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added dependsOnLayer()
...
#991
Merged
msbarry
merged 8 commits into
onthegomap:main
from
phanecak-maptiler:onlyLayers_and_excludeLayers-handle_also_dependencies
Aug 27, 2024
Merged
added dependsOnLayer()
...
#991
msbarry
merged 8 commits into
onthegomap:main
from
phanecak-maptiler:onlyLayers_and_excludeLayers-handle_also_dependencies
Aug 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... so that caresAboutLayer() can handle situations when somelayer depends on another layer, e.g. for example in OpenMapTiles: - when 'transportation' is exluded, then also 'transportation_name' needs to be also treated as exluded - when 'transportation' is included (e.g. mentioned in --only-layers) then 'transportation_name' needs to be also treated as included`
Full logs: https://github.com/onthegomap/planetiler/actions/runs/10578298010 |
msbarry
reviewed
Aug 22, 2024
planetiler-core/src/main/java/com/onthegomap/planetiler/ForwardingProfile.java
Outdated
Show resolved
Hide resolved
... so that if a layer "transportation_name" depends on "transportation" and "transportation_name" already got past caresAboutLayer(), then subsequent attempt to add "transportation" will get past caresAboutLayer() too
msbarry
reviewed
Aug 23, 2024
planetiler-core/src/main/java/com/onthegomap/planetiler/ForwardingProfile.java
Outdated
Show resolved
Hide resolved
msbarry
reviewed
Aug 23, 2024
planetiler-core/src/main/java/com/onthegomap/planetiler/ForwardingProfile.java
Outdated
Show resolved
Hide resolved
msbarry
reviewed
Aug 23, 2024
planetiler-core/src/main/java/com/onthegomap/planetiler/ForwardingProfile.java
Outdated
Show resolved
Hide resolved
msbarry
reviewed
Aug 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment otherwise looks good!
planetiler-core/src/main/java/com/onthegomap/planetiler/ForwardingProfile.java
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
msbarry
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... so that
caresAboutLayer()
can handle situations when some layer depends on another layer, e.g. for example in OpenMapTiles:when 'transportation' is excluded, then also 'transportation_name' needs to be also treated as excludedThis is a follow-up on #968.