Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Federated search results merging logic #872

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Fix: Federated search results merging logic #872

merged 1 commit into from
Nov 26, 2024

Conversation

Bilelkihal
Copy link
Collaborator

Related issue: #868

Changes

  • Update the logic for merging federated search results. Previously, we checked for duplications only by examining reuses, which missed certain cases. In this PR, we address those cases by explicitly verifying the entire list of results.(21fdebb)

Bilelkihal
Bilelkihal commented Nov 25, 2024
View reviewed changes
Copy link
Collaborator Author

@Bilelkihal Bilelkihal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@Bilelkihal
Copy link
Collaborator Author

Deployed to stage

@syphax-bouazzouni
Copy link
Collaborator

Add a before and after screenshot, or an example to tests. @Bilelkihal

@Bilelkihal
Copy link
Collaborator Author

Add a before and after screenshot, or an example to tests. @Bilelkihal

@syphax-bouazzouni
We lost the before, it's already deployed to stage 😅.
Try to reproduce the issue here: #868 you will find that the merging is now done correctly 👌

syphax-bouazzouni
syphax-bouazzouni approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@syphax-bouazzouni syphax-bouazzouni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, all fine and merged.

@syphax-bouazzouni syphax-bouazzouni merged commit 450ddf4 into development Nov 26, 2024
6 of 8 checks passed
This was referenced Nov 26, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syphax-bouazzouni syphax-bouazzouni syphax-bouazzouni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bilelkihal @syphax-bouazzouni