Feature: implement ontology agents endpoint #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #84 +/- ##
===============================================
+ Coverage 71.26% 71.68% +0.41%
===============================================
Files 67 67
Lines 3508 3662 +154
===============================================
+ Hits 2500 2625 +125
- Misses 1008 1037 +29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
controllers/agents_controller.rb
Outdated
| @@ -1,5 +1,24 @@ | |||
| class AgentsController < ApplicationController | |||
|
|
|||
| # Ontology agents | |||
…agents' that contains all the agents of the ontology using agents_attrs list
| ontologies_and_submissions = create_ontologies_and_submissions(ont_count: 1, submission_count: 1, process_submission: true) | ||
| submission = ontologies_and_submissions[2].first.submissions.last | ||
| ontology_acronym = ontologies_and_submissions[1].first | ||
| submission.bring(*OntologySubmission.agents_attrs) |
There was a problem hiding this comment.
do instead submission.bring_remaining
There was a problem hiding this comment.
Why? (we need only agent attributes in this endpoint)
| @@ -282,11 +282,100 @@ def test_detach_a_view | |||
| assert_equal onto["viewOf"], ont.id.to_s | |||
| end | |||
|
|
|||
| def test_ontology_agents | |||
| ontologies_and_submissions = create_ontologies_and_submissions(ont_count: 1, submission_count: 1, process_submission: true) | |||
There was a problem hiding this comment.
do process_submission: false, so that the tests is faster.
There was a problem hiding this comment.
When I do process submission false I get this error:
… number of results and the names
Bilelkihal
force-pushed
the
feature/add-ontology-agents-endpoint
branch
from
7b17e93 to
8d47007
Compare
|
Done ✅ |
syphax-bouazzouni
added a commit
that referenced
this pull request
Aug 8, 2024
* Feature: mappings statistics slices support (#78) * restrict mapping statistics ontologies to the ontologies of the current slice * add a test for the mappings slices support * add test for mappings statistics slices support * update owl wrapper version to v1.4.3 * update test search multilingual test to ensure selecting one prefLabel * add filter search results attributes by language * add search multiple languages or all languages tests * implement display search results in multiple languages * fix annotator prefLabel language selection * fix: remove duplicated agents endpoint ('/Agents') (#85) * Feature: implement ontology agents endpoint (#84) * implement ontology agents endpoint * Move ontology agents method out of agents namespace in agents_controller * return a list of uniq values, for the endpoint '/ontologies/:acronym/agents' that contains all the agents of the ontology using agents_attrs list * test for ontology agents endpoing * add another ontologyin test ontology agents test, and assert only the number of results and the names --------- Co-authored-by: Bilel KIHAL <[email protected]> * update API deploy CI to SSH jump host and get configs from private repo * update deploy files and add agroportal, stage and test environments * Feature: update agents search endpoint to add option to have a custom qf paramter (#90) * fix agents search sensibility * improve agents search endpoint to search only exact string or substring match * make the agent search endpoint query filter configurable --------- Co-authored-by: Syphax <[email protected]> * Fix: hide duplicated agents endpoint ('/Agents') (#91) * remove duplicated agents endpoint ('/Agents') * put again the Agents endpoint * hide Agents endpoint in the home endpoint * fix properties tests --------- Co-authored-by: Bilel KIHAL <[email protected]> --------- Co-authored-by: Bilel Kihal <[email protected]> Co-authored-by: Bilel KIHAL <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require
Changes