-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: remove duplicated agents root #85
Fix: remove duplicated agents root #85
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to see if there's an issue with '/agents' in ruby client before merging
@syphax-bouazzouni You can merge it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it will not work in the UI side, I can deploy it to stageportal so that you test if you want
Yes deploy it, so I can debug it in ontologies_api_ruby_client |
@Bilelkihal here try the call to find one Agent. |
The unique issue that I found with removing the |
Done ✅ |
* Feature: mappings statistics slices support (#78) * restrict mapping statistics ontologies to the ontologies of the current slice * add a test for the mappings slices support * add test for mappings statistics slices support * update owl wrapper version to v1.4.3 * update test search multilingual test to ensure selecting one prefLabel * add filter search results attributes by language * add search multiple languages or all languages tests * implement display search results in multiple languages * fix annotator prefLabel language selection * fix: remove duplicated agents endpoint ('/Agents') (#85) * Feature: implement ontology agents endpoint (#84) * implement ontology agents endpoint * Move ontology agents method out of agents namespace in agents_controller * return a list of uniq values, for the endpoint '/ontologies/:acronym/agents' that contains all the agents of the ontology using agents_attrs list * test for ontology agents endpoing * add another ontologyin test ontology agents test, and assert only the number of results and the names --------- Co-authored-by: Bilel KIHAL <[email protected]> * update API deploy CI to SSH jump host and get configs from private repo * update deploy files and add agroportal, stage and test environments * Feature: update agents search endpoint to add option to have a custom qf paramter (#90) * fix agents search sensibility * improve agents search endpoint to search only exact string or substring match * make the agent search endpoint query filter configurable --------- Co-authored-by: Syphax <[email protected]> * Fix: hide duplicated agents endpoint ('/Agents') (#91) * remove duplicated agents endpoint ('/Agents') * put again the Agents endpoint * hide Agents endpoint in the home endpoint * fix properties tests --------- Co-authored-by: Bilel KIHAL <[email protected]> --------- Co-authored-by: Bilel Kihal <[email protected]> Co-authored-by: Bilel KIHAL <[email protected]>
Related issue:
agroportal/project-management#471
Related GOO PR:
ontoportal-lirmm/goo#62