Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: remove duplicated agents root #85

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

Bilelkihal
Copy link
Collaborator

@Bilelkihal Bilelkihal commented Jul 17, 2024

@Bilelkihal Bilelkihal added the bug label Jul 17, 2024
@Bilelkihal Bilelkihal self-assigned this Jul 17, 2024
Copy link
Collaborator Author

@Bilelkihal Bilelkihal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to see if there's an issue with '/agents' in ruby client before merging

@Bilelkihal
Copy link
Collaborator Author

I tested also the UI with ontologies_api_ruby_client and it's doing calls using the lowercase /agents, see the screenshot below
image

@Bilelkihal
Copy link
Collaborator Author

@syphax-bouazzouni You can merge it

Copy link

@syphax-bouazzouni syphax-bouazzouni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will not work in the UI side, I can deploy it to stageportal so that you test if you want

@Bilelkihal
Copy link
Collaborator Author

Bilelkihal commented Jul 17, 2024

Yes deploy it, so I can debug it in ontologies_api_ruby_client

@syphax-bouazzouni
Copy link

syphax-bouazzouni commented Jul 18, 2024

I tested also the UI with ontologies_api_ruby_client and it's doing calls using the lowercase /agents, see the screenshot below image

@Bilelkihal here try the call to find one Agent.

I deployed this branch in stage, so that can do you tests
image

@syphax-bouazzouni
Copy link

The unique issue that I found with removing the Agents endpoint is not in the UI but in the API if you go to https://data.stageportal.lirmm.fr/agents endpoint and click on one of the IDs, it will return a not found page.
Example: https://data.stageportal.lirmm.fr/Agents/565540a0-3018-013c-5eb5-5254007cab39
image

@Bilelkihal
Copy link
Collaborator Author

Bilelkihal commented Jul 19, 2024

The problem is not only in the object Agent, but also for the AgentIdentifier for example and I believe some more others and the problem was here in GOO project the method uuid_uri_generator, we need to downcase the modelname before passing it to the URI:
image

I'll create a PR in GOO project for this

@Bilelkihal
Copy link
Collaborator Author

Done ✅

@syphax-bouazzouni syphax-bouazzouni merged commit ab38c60 into development Jul 23, 2024
24 checks passed
syphax-bouazzouni added a commit that referenced this pull request Aug 8, 2024
* Feature: mappings statistics slices support (#78)

* restrict mapping statistics ontologies to the ontologies of the current slice

* add a test for the mappings slices support

* add test for mappings statistics slices support

* update owl wrapper version to v1.4.3

* update test search multilingual test to ensure selecting one prefLabel

* add filter search results attributes by language

* add search  multiple languages or all languages tests

* implement display search results in multiple languages

* fix annotator prefLabel language selection

* fix: remove duplicated agents endpoint ('/Agents') (#85)

* Feature: implement ontology agents endpoint (#84)

* implement ontology agents endpoint

* Move ontology agents method out of agents namespace in agents_controller

* return a list of uniq values, for the endpoint '/ontologies/:acronym/agents' that contains all the agents of the ontology using agents_attrs list

* test for ontology agents endpoing

* add another ontologyin test ontology agents test, and assert only the number of results and the names

---------

Co-authored-by: Bilel KIHAL <[email protected]>

* update API deploy CI  to SSH jump host and get configs from private repo

* update deploy files and add agroportal, stage and test environments

* Feature: update agents search endpoint to add option to have a custom qf paramter  (#90)

* fix agents search sensibility

* improve agents search endpoint to search only exact string or substring match

* make the agent search endpoint query filter configurable

---------

Co-authored-by: Syphax <[email protected]>

* Fix: hide duplicated agents endpoint ('/Agents')  (#91)

* remove duplicated agents endpoint ('/Agents')

* put again the Agents endpoint

* hide Agents endpoint in the home endpoint

* fix properties tests

---------

Co-authored-by: Bilel KIHAL <[email protected]>

---------

Co-authored-by: Bilel Kihal <[email protected]>
Co-authored-by: Bilel KIHAL <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants