Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Move index func from addon framework to ocm #728

Merged
merged 2 commits into from
Dec 2, 2024

Address code review comments

a75c1f0
Select commit
Loading
Failed to load commit list.
Merged

🌱 Move index func from addon framework to ocm #728

Address code review comments
a75c1f0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 2, 2024 in 0s

63.32% (-0.16%) compared to 93db6de

View this Pull Request on Codecov

63.32% (-0.16%) compared to 93db6de

Details

Codecov Report

Attention: Patch coverage is 16.66667% with 60 lines in your changes missing coverage. Please review.

Project coverage is 63.32%. Comparing base (93db6de) to head (a75c1f0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/addon/index/index.go 9.67% 53 Missing and 3 partials ⚠️
...addon/controllers/addonconfiguration/controller.go 33.33% 2 Missing ⚠️
...kg/addon/controllers/addonmanagement/controller.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #728      +/-   ##
==========================================
- Coverage   63.48%   63.32%   -0.16%     
==========================================
  Files         185      186       +1     
  Lines       17827    17900      +73     
==========================================
+ Hits        11317    11335      +18     
- Misses       5578     5629      +51     
- Partials      932      936       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov