[OF#3755] Datetime validation #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #636 +/- ##
==========================================
+ Coverage 73.04% 73.74% +0.69%
==========================================
Files 219 220 +1
Lines 4474 4498 +24
Branches 1186 1192 +6
==========================================
+ Hits 3268 3317 +49
+ Misses 1167 1142 -25
Partials 39 39 ☔ View full report in Codecov by Sentry. |
SilviaAmAm
force-pushed
the
fix/3755-datetime-validation
branch
from
ca98e41 to
8a6bf59
Compare
If the datetime is entered with the keyboard instead of the widget, no validation was being performed. This adds the validation in the same way as for the date component (see open-formulieren/open-forms#3443)
SilviaAmAm
force-pushed
the
fix/3755-datetime-validation
branch
from
8a6bf59 to
25589d3
Compare
vaszig
approved these changes
Jan 19, 2024
src/formio/validators/utils.js
Outdated
| return {isValid: true}; | ||
| } | ||
|
|
||
| const parsedValue = parseISO(value, 'yyyy-MM-dd', new Date()); |
There was a problem hiding this comment.
shouldn't the format be dependent on the componentType too?
There was a problem hiding this comment.
This actually doesn't seem to be used 🤔 parseIso does not have a format argument 🤔 https://date-fns.org/v2.3.0/docs/parseISO#arguments
I will remove these extra args
SilviaAmAm
force-pushed
the
fix/3755-datetime-validation
branch
from
434d7f6 to
eb4def7
Compare
sergei-maertens
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes open-formulieren/open-forms#3755 (partially)