⬆️ Upgrade to Vite 6 #758
Open
⬆️ Upgrade to Vite 6 #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #758 +/- ##
==========================================
- Coverage 80.05% 80.02% -0.03%
==========================================
Files 238 238
Lines 4953 4951 -2
Branches 1350 1341 -9
==========================================
- Hits 3965 3962 -3
- Misses 958 959 +1
Partials 30 30 ☔ View full report in Codecov by Sentry. |
|
Blocked by storybookjs/storybook#29719 :) |
sergei-maertens
force-pushed
the
chore/upgrade-vite-6
branch
from
cd9f403 to
9607a25
Compare
Released a couple of weeks ago :) This currently requires us to force storybook vite builder to resolve esbuild to 0.24.0, despite vite 6.0.5 pinning this dependency. See storybookjs/storybook#30115
sergei-maertens
force-pushed
the
chore/upgrade-vite-6
branch
from
9607a25 to
d5c38bb
Compare
|
Workaround applied from pinned Storybook issue. |
1 task
|
@robinmolen @vaszig considering this is build tooling and CI is passing, I think it's not too extreme to merge this in main before the 2.5.0 release, but feel free to disagree if you think it's too risky! |
vaszig
reviewed
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Released a couple of weeks ago :)