Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Als gemeente wil ik user-input valideren dmv data uit het Basisregistratie Kadaster (BRK) #3607

Closed
8 tasks done
joeribekker opened this issue Nov 14, 2023 · 1 comment · Fixed by #3646 or open-formulieren/open-forms-sdk#623

Comments

@joeribekker
Copy link
Contributor

joeribekker commented Nov 14, 2023

Als formulierontwikkelaar wil ik een koppeling maken met het BRK, om bepaalde user-input te valideren met de data die in het BRK opgeslagen staat.

Ref: DH 609

Voorbeeld

Formulier: Heruitgifte erfpacht aanvragen

  • User logt in met DigiD
  • Controle BRK: is de naam van de aanvrager (volgens inlog DigiD/BRP) van de aanvrager gelijk aan de geregistreerde zakelijk gerechtigde voor het adres waarvoor de aanvraag geldt in de BRK?

Indien correct: user kan doorgaan naar volgende stap

Indien niet correct, toon foutmelding:

Uit controle van uw gegevens blijkt dat u deze aanvraag niet kunt doen. Voor meer informatie neem contact op [...]

@joeribekker joeribekker added this to the Release 2.5.0 milestone Nov 14, 2023
@joeribekker joeribekker added triage Issue needs to be validated. Remove this label if the issue considered valid. and removed triage Issue needs to be validated. Remove this label if the issue considered valid. labels Nov 14, 2023
@joeribekker
Copy link
Contributor Author

joeribekker commented Nov 23, 2023

Refinement: Discussed various options:

  1. Using a validator - We had trouble defining on which component this validator should be AND it requires you to select the postalcode and housenumber fields manually.
  2. Using form logic - We cannot attach the logic action to a specific field, and we need to link it to the components like 1.
  3. Step logic/validator - This would be new entirely. If we see more features that fit in this we might re-evaluate doing this but for now too big
  4. Validator on pre-defined composed components (address) - This would be new, to have a component that holds multiple fields. But we do have all fields we need for the validator.

We're trying out 4 (iv) and that implies these tasks:

Tasks

  1. Address component that shows fields "postal code" and "housenumber", "houseletter", "house addition"
  2. Validator can be added "BRK - Zaakgerechtigde"
  3. Validator gets with above fields, the address: https://vng-realisatie.github.io/Haal-Centraal-BRK-bevragen/redoc-2.0#tag/Kadastraal-Onroerende-Zaken/operation/GetKadastraalOnroerendeZaken (option 4)
  4. With the resulting kadastraleindeiticatie (property id), you can call https://vng-realisatie.github.io/Haal-Centraal-BRK-bevragen/redoc-2.0#tag/Zakelijke-Gerechtigden/operation/GetZakelijkGerechtigden and compare the logged in BSN with the person identifier.

@Viicos Viicos moved this from Todo to In Progress in Development Nov 23, 2023
Viicos added a commit that referenced this issue Nov 30, 2023
Viicos added a commit that referenced this issue Dec 5, 2023
Viicos added a commit that referenced this issue Dec 6, 2023
Viicos added a commit to open-formulieren/open-forms-sdk that referenced this issue Dec 6, 2023
Viicos added a commit that referenced this issue Dec 6, 2023
Viicos added a commit that referenced this issue Dec 6, 2023
Viicos added a commit that referenced this issue Dec 6, 2023
Viicos added a commit that referenced this issue Dec 6, 2023
Viicos added a commit that referenced this issue Dec 6, 2023
Viicos added a commit that referenced this issue Dec 6, 2023
@github-project-automation github-project-automation bot moved this from Done to In Progress in Development Jan 5, 2024
@Viicos Viicos moved this from In Progress to Implemented in Development Jan 5, 2024
Viicos added a commit that referenced this issue Jan 5, 2024
... to be up to date with the current OF standard
Only implementation is changed in this commit, tests will follow
Viicos added a commit that referenced this issue Jan 5, 2024
sergei-maertens added a commit to open-formulieren/open-forms-sdk that referenced this issue Jan 5, 2024
Viicos added a commit that referenced this issue Jan 5, 2024
@sergei-maertens sergei-maertens moved this from Implemented to In Progress in Development Jan 7, 2024
Viicos added a commit that referenced this issue Jan 8, 2024
... to be up to date with the current OF standard
Only implementation is changed in this commit, tests will follow
Viicos added a commit that referenced this issue Jan 8, 2024
Viicos added a commit that referenced this issue Jan 8, 2024
sergei-maertens added a commit to open-formulieren/open-forms-sdk that referenced this issue Jan 8, 2024
This is *not* the level of quality we stand for, but it is costing
unreasonable amounts of time and effort to try to get a grip on the
interaction tests and state synchronization, without any guarantees
or conviction that we'll actually manage to sort it out.

Perhaps if we can upgrade Storybook and get testing-library v14 with
async user events things might get better, but that itself is a
non-trivial undertaking.

We now make sure that on every React re-render (due to validating
state changes) we also make sure to check if we need to fire the
formio blur event to trigger our formio-level validation.
sergei-maertens added a commit to open-formulieren/open-forms-sdk that referenced this issue Jan 8, 2024
sergei-maertens added a commit to open-formulieren/open-forms-sdk that referenced this issue Jan 8, 2024
Ensure the validation error messages are translated and sufficiently
accessible for people using screen readers (meaning the field label
must be mentioned in the validation error message).
Viicos added a commit that referenced this issue Jan 8, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Development Jan 8, 2024
sergei-maertens added a commit to open-formulieren/open-forms-sdk that referenced this issue Jan 9, 2024
Ensure the validation error messages are translated and sufficiently
accessible for people using screen readers (meaning the field label
must be mentioned in the validation error message).
Viicos added a commit that referenced this issue Jan 9, 2024
Viicos added a commit that referenced this issue Jan 9, 2024
... to be up to date with the current OF standard
Only implementation is changed in this commit, tests will follow
Viicos added a commit that referenced this issue Jan 9, 2024
Viicos added a commit that referenced this issue Jan 9, 2024
Viicos added a commit that referenced this issue Jan 9, 2024
Viicos added a commit that referenced this issue Jan 10, 2024
Viicos added a commit that referenced this issue Jan 10, 2024
Viicos added a commit that referenced this issue Jan 11, 2024
sergei-maertens pushed a commit that referenced this issue Jan 12, 2024
... to be up to date with the current OF standard.

We now only support class based validation plugins due to the
extra configuration that is needed and the ability to target
specific value types (string, dictionary, number...).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment