[#3607] Refactor validation plugin, add BRK validator #3646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
8 tasks
Viicos
force-pushed
the
feature/3607-brk-validator
branch
from
2b2e627 to
a6eb071
Compare
Closed
8 tasks
Viicos
force-pushed
the
feature/3607-brk-validator
branch
4 times, most recently
from
6c5ae2f to
507f855
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3646 +/- ##
==========================================
+ Coverage 96.06% 96.09% +0.03%
==========================================
Files 691 698 +7
Lines 22200 22398 +198
Branches 2565 2581 +16
==========================================
+ Hits 21326 21524 +198
Misses 603 603
Partials 271 271 ☔ View full report in Codecov by Sentry. |
Viicos
force-pushed
the
feature/3607-brk-validator
branch
2 times, most recently
from
ab6929b to
70e2b6a
Compare
|
Blocked by adding the formio-builder v0.11.0 in a separate PR |
Viicos
force-pushed
the
feature/3607-brk-validator
branch
from
940910d to
e41dac7
Compare
sergei-maertens
requested changes
Dec 29, 2023
Comment on lines
+57
to
+46
| def function_validator(value, submission): | ||
| if value != "VALID": | ||
| raise DjangoValidationError("not VALID value") | ||
|
|
||
|
|
||
| function_validator.value_serializer = StringValueSerializer |
There was a problem hiding this comment.
oh this only concerns tests to set the attribute? If we don't have any actual function-based validator implementations, just drop support for it.
There was a problem hiding this comment.
I think the next refactor PR handles this
Viicos
force-pushed
the
feature/3607-brk-validator
branch
from
ddba05f to
3324c2f
Compare
sergei-maertens
requested changes
Jan 4, 2024
Viicos
force-pushed
the
feature/3607-brk-validator
branch
from
97ae267 to
aab22d0
Compare
sergei-maertens
approved these changes
Jan 5, 2024
Viicos
force-pushed
the
feature/3607-brk-validator
branch
from
f7634c8 to
aa5b890
Compare
To be able to use latest typing features
Viicos
force-pushed
the
feature/3607-brk-validator
branch
from
aa5b890 to
e11ab50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly closes #3607