Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Co-sign component stalls submission even when field is hidden #3901

Closed
hlmr-erik opened this issue Feb 16, 2024 · 2 comments · Fixed by #4889
Closed

Co-sign component stalls submission even when field is hidden #3901

hlmr-erik opened this issue Feb 16, 2024 · 2 comments · Fixed by #4889

Comments

@hlmr-erik
Copy link

hlmr-erik commented Feb 16, 2024

Product versie / Product version

2.4.5

Omschrijf het probleem / Describe the bug

We conditionally show the co-sign field based on a preceding choice. Even when the field is hidden, the submission is now stalled for co-sign; as apparently (Taiga HLMR 86) the stalled-for-co-sign is triggered by the form containing a required co-sign component, whether this component is hidden or not. Making the field non-required through logic, based on mentioned preceding choice, seemed workable; but in this case the form still gets stalled.

Stappen om te reproduceren / Steps to reproduce

-Add a radiogroup to a form
-Add a required co-sign component to the form
-Set the co-sign component to appear only when one of the radiogroup choices is made

Further steps to reproduce the workaround failing:
-Add a rule on the logic tab, specifying the co-sign field to be marked not-required based on a choice in the radiogroup
-Make said choice
-Observe the form still gets stalled after submission.

Verwacht gedrag / Expected behavior

For the form to be stalled for co-sign only then and when the element is 1. Shown and 2. Required.

Screen resolution

None

Device

None

OS

None

Browser

No response

@hlmr-erik hlmr-erik added bug triage Issue needs to be validated. Remove this label if the issue considered valid. labels Feb 16, 2024
@sergei-maertens sergei-maertens added owner: haarlemmermeer and removed triage Issue needs to be validated. Remove this label if the issue considered valid. labels Feb 19, 2024
@sergei-maertens
Copy link
Member

Looking at the current code (master@565e5d1787c699b791472a69e2f51028dd3b415f, 3.0.0-alpha.1) this is still the case, and an important consideration for Cosign v3

@hlmr-erik I'm currently wrapping up a number of cosign improvements and looking forward to the future. Would it be acceptable for you if the cosign 'component' is moved/hardcoded to be on the summary/confirmation page? We will of course still make it possible to make cosigning required/optional through form logic.

@sergei-maertens sergei-maertens self-assigned this Dec 6, 2024
@sergei-maertens sergei-maertens added this to the Release 3.0 milestone Dec 6, 2024
@sergei-maertens sergei-maertens moved this from Todo to Implemented in Development Dec 6, 2024
@sergei-maertens
Copy link
Member

#4888 made it possible to work on a fix for this 🎉 it will be included in Open Forms 3.0

sergei-maertens added a commit that referenced this issue Dec 6, 2024
A required but hidden cosign component should not block the submission
registration.
sergei-maertens added a commit that referenced this issue Dec 6, 2024
When cosign components are (dynamically) hidden, this effectively makes
the form/submission *not* a cosign form. However, due to logic not
being taken into account, the mere presence of a required cosign
component would block the registration by waiting for cosign.
sergei-maertens added a commit that referenced this issue Dec 6, 2024
A required but hidden cosign component should not block the submission
registration.
sergei-maertens added a commit that referenced this issue Dec 6, 2024
When cosign components are (dynamically) hidden, this effectively makes
the form/submission *not* a cosign form. However, due to logic not
being taken into account, the mere presence of a required cosign
component would block the registration by waiting for cosign.
sergei-maertens added a commit that referenced this issue Dec 9, 2024
A required but hidden cosign component should not block the submission
registration.
sergei-maertens added a commit that referenced this issue Dec 9, 2024
When cosign components are (dynamically) hidden, this effectively makes
the form/submission *not* a cosign form. However, due to logic not
being taken into account, the mere presence of a required cosign
component would block the registration by waiting for cosign.
sergei-maertens added a commit that referenced this issue Dec 10, 2024
A required but hidden cosign component should not block the submission
registration.
sergei-maertens added a commit that referenced this issue Dec 10, 2024
When cosign components are (dynamically) hidden, this effectively makes
the form/submission *not* a cosign form. However, due to logic not
being taken into account, the mere presence of a required cosign
component would block the registration by waiting for cosign.
@github-project-automation github-project-automation bot moved this from Implemented to Done in Development Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment