Refactor validation plugins #3701
Conversation
… values than `str` Add a formatter for the address component Few typing fixes related to the registry Fix BRK validation based on the first E2E tests
API key was redacted
Add the new validator to the list. This list is now sorted to ensure consistency.
... to be up to date with the current OF standard Only implementation is changed in this commit, tests will follow
|
It looks like there are some commits included here that shouldn't, e.g. all the addressNL related commits? |
|
This was checked out from feature/3607-brk-validator. If merged, GH will automatically rebase this branch onto |
But both that PR and this one have the exact same set of commits. I was under the impression that a validator refactor PR would be based on master, apply the refactor and then the BRK validator PR would be rebased on that result where the new validator is then added. I'm very confused now. |
This PR has the following extra commit: 4e0293a
The issue is some refactor was already done in the BRK PR, namely having the submission being passed in in validators. Having the refactor based on |
|
Ah, both have 17 commits but only commits 17 are different, I see now. Okay, I've marked it as draft so that the other PR can be sorted out first. |
|
Superseded by #3741 |
Part of #3607
Depends on #3646