Refactor validation plugins #3741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Viicos
force-pushed
the
feature/refactor-validation-plugins
branch
3 times, most recently
from
6c65234 to
8d8d4b7
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3741 +/- ##
==========================================
+ Coverage 96.14% 96.15% +0.01%
==========================================
Files 699 700 +1
Lines 22499 22506 +7
Branches 2602 2597 -5
==========================================
+ Hits 21631 21641 +10
+ Misses 596 595 -1
+ Partials 272 270 -2 ☔ View full report in Codecov by Sentry. |
Viicos
commented
Jan 8, 2024
Viicos
force-pushed
the
feature/refactor-validation-plugins
branch
from
1601206 to
becb03f
Compare
sergei-maertens
requested changes
Jan 10, 2024
Viicos
force-pushed
the
feature/refactor-validation-plugins
branch
from
f843ca2 to
e04bfac
Compare
... to be up to date with the current OF standard. We now only support class based validation plugins due to the extra configuration that is needed and the ability to target specific value types (string, dictionary, number...).
sergei-maertens
force-pushed
the
feature/refactor-validation-plugins
branch
from
e04bfac to
24096ce
Compare
sergei-maertens
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picked from #3701