DMN config checks / digest email #4413
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4413 +/- ##
==========================================
- Coverage 96.50% 96.22% -0.29%
==========================================
Files 720 720
Lines 23845 23944 +99
Branches 2813 2835 +22
==========================================
+ Hits 23012 23039 +27
- Misses 565 634 +69
- Partials 268 271 +3 ☔ View full report in Codecov by Sentry. |
DMN action checks are also logic rule checks, so the collector function and context variables are renamed to better cover what they actually detect.
Added explicit message parameter that can be accessed, instead of having to rely on exc.args[0] which *could* be empty. Now you must instantiate this exception with a message argument. The message is still forwarded to the parent exception in case other usages still rely on exc.args[0], but this will be refactored later.
Detect which DMN plugins are enabled and used in (live) forms, and run the config check for them. If problems are detected, they will be reported in the digest email.
sergei-maertens
force-pushed
the
feature/4284-dmn-config-checks
branch
from
0b72d29 to
179e277
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4284
Changes
...
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh./bin/compilemessages_js.shCommit hygiene