Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4267] Convert Objects API V1 tests to VCR #4548

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented Jul 22, 2024

Partly closes #4267

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

Viicos added 2 commits July 22, 2024 17:51
Added fixtures necessary to update existing tests
Update to latest Objects API version, as it fixes a bug when sending
empty data
Update dump command to not dump object records
@Viicos Viicos force-pushed the feature/4267-convert-vcr branch from b03b13c to 7edbdf0 Compare July 23, 2024 08:57
@Viicos Viicos marked this pull request as ready for review July 23, 2024 09:04
@Viicos
Copy link
Contributor Author

Viicos commented Jul 23, 2024

I kept test_backend.py out of scope as it has some mocks setup to fail, which would be harder to reproduce using VCR.

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.60%. Comparing base (9280bb2) to head (b11f979).
Report is 494 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4548   +/-   ##
=======================================
  Coverage   96.60%   96.60%           
=======================================
  Files         725      725           
  Lines       24125    24125           
  Branches     2870     2870           
=======================================
  Hits        23305    23305           
  Misses        559      559           
  Partials      261      261           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sergei-maertens sergei-maertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it

@sergei-maertens sergei-maertens merged commit a0e2e18 into master Jul 23, 2024
30 checks passed
@sergei-maertens sergei-maertens deleted the feature/4267-convert-vcr branch July 23, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow specifying the documents API in the objects API registration
2 participants