✨ [#4789] ConfigurationStep for ZGW API registration config #4876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4876 +/- ##
=======================================
Coverage 96.60% 96.61%
=======================================
Files 754 756 +2
Lines 25853 25888 +35
Branches 3415 3416 +1
=======================================
+ Hits 24976 25011 +35
Misses 613 613
Partials 264 264 ☔ View full report in Codecov by Sentry. |
stevenbal
force-pushed
the
feature/setup-configuration
branch
from
67390e6 to
6024de6
Compare
stevenbal
force-pushed
the
feature/4789-zgw-setup-config
branch
from
069904d to
3e4729c
Compare
stevenbal
force-pushed
the
feature/setup-configuration
branch
2 times, most recently
from
4380c06 to
5cb5618
Compare
stevenbal
force-pushed
the
feature/4789-zgw-setup-config
branch
2 times, most recently
from
d9e3c8d to
ee7fe3b
Compare
stevenbal
force-pushed
the
feature/setup-configuration
branch
2 times, most recently
from
4f92c5b to
0d16714
Compare
stevenbal
force-pushed
the
feature/4789-zgw-setup-config
branch
from
ee7fe3b to
71e813c
Compare
stevenbal
force-pushed
the
feature/setup-configuration
branch
2 times, most recently
from
edd2b72 to
07c23a6
Compare
to make sure there is a unique field that can be used to refer to the groups and identify them when they are loaded using setup-configuration
stevenbal
force-pushed
the
feature/4789-zgw-setup-config
branch
2 times, most recently
from
f7297fb to
d228755
Compare
stevenbal
commented
Dec 6, 2024
| ZGWApiGroupConfig, "content_json" | ||
| ) | ||
|
|
||
| # FIXME choices and blank=True doesn't seem to be picked up properly |
There was a problem hiding this comment.
Created an issue in django-setup-configuration for this maykinmedia/django-setup-configuration#27
|
@sergei-maertens I rebased and this PR is now ready for review |
sergei-maertens
requested changes
Dec 6, 2024
src/openforms/registrations/contrib/zgw_apis/tests/factories.py
Outdated
Show resolved
Hide resolved
stevenbal
force-pushed
the
feature/4789-zgw-setup-config
branch
from
d228755 to
cc0d8bf
Compare
Comment on lines
+79
to
+87
| objects_api_json_content_template: | | ||
| { | ||
| "data": {% json_summary %}, | ||
| "type": "{{ productaanvraag_type }}", | ||
| "bsn": "{{ variables.auth_bsn }}", | ||
| "submission_id": "{{ submission.kenmerk }}", | ||
| "language_code": "{{ submission.language_code }}", | ||
| "custom_field": "foo" | ||
| } |
There was a problem hiding this comment.
I only now realize you can't specify an objects API group at the model level 🤔
There was a problem hiding this comment.
is this the same issue as previously with objects API registration where it would always use the group with the lowest pk?
sergei-maertens
requested changes
Dec 9, 2024
stevenbal
force-pushed
the
feature/4789-zgw-setup-config
branch
from
cc0d8bf to
fd0d626
Compare
this step relies on the previously added ServiceConfigurationStep and can be used to set up the necessary configuration for the ZGW API registration backend
stevenbal
force-pushed
the
feature/4789-zgw-setup-config
branch
from
fd0d626 to
df117af
Compare
|
@sergei-maertens I was running into 504 errors in the generate SDK jobs: https://github.com/open-formulieren/open-forms/actions/runs/12231486625/job/34115402181, I hope this fixes it: 67db7c4 |
the generate-sdks job was failing due to some network calls that were performed when validating the OAS, this is avoided by specifying the version of the generator-cli in openapitools.json see also: OpenAPITools/openapi-generator-cli#802
stevenbal
force-pushed
the
feature/4789-zgw-setup-config
branch
from
67db7c4 to
6635402
Compare
sergei-maertens
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4789
Closes #4532
Changes
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh./bin/compilemessages_js.shCommit hygiene