Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] use only gci linter #36511

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[chore] use only gci linter #36511

wants to merge 1 commit into from

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Nov 23, 2024 •
edited
Loading

Description

There are actually two linters that handle imports order (goimports and gci)

This uses only gci as the linter to order imports

@mmorel-35 mmorel-35 force-pushed the golangci-lint/gci branch 2 times, most recently from 80959d6 to fb4e5ef Compare November 23, 2024 10:02
@mmorel-35 mmorel-35 marked this pull request as draft November 23, 2024 10:17
@mmorel-35
Copy link
Contributor Author

There seems to be problem with mdatagen and noop import is missing in generated_telemetry.go files

@atoulme
Copy link
Contributor

atoulme commented Dec 7, 2024

Please rebase and run make generate

@mmorel-35 mmorel-35 force-pushed the golangci-lint/gci branch 4 times, most recently from d1ca5f1 to 26f5f1f Compare December 7, 2024 09:44
@mmorel-35
[chore] use only gci linter
4812dc1 
Signed-off-by: Matthieu MOREL <[email protected]>
@mmorel-35
Copy link
Contributor Author

mmorel-35 commented Dec 7, 2024 •
edited
Loading

There are still some trouble with imports.
Probably worth some fixes in mdatagen

/cc @bogdandrutu ,
I'll provide a PR

@mmorel-35 mmorel-35 mentioned this pull request Dec 8, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmacd jmacd Awaiting requested review from jmacd jmacd is a code owner

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner

@atoulme atoulme Awaiting requested review from atoulme atoulme is a code owner

@MovieStoreGuy MovieStoreGuy Awaiting requested review from MovieStoreGuy MovieStoreGuy is a code owner

@TylerHelmuth TylerHelmuth Awaiting requested review from TylerHelmuth TylerHelmuth is a code owner

@jpkrohling jpkrohling Awaiting requested review from jpkrohling jpkrohling is a code owner

@fatsheep9146 fatsheep9146 Awaiting requested review from fatsheep9146 fatsheep9146 is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@ChrsMark ChrsMark Awaiting requested review from ChrsMark ChrsMark will be requested when the pull request is marked ready for review ChrsMark is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@fatsheep9146 fatsheep9146

Labels
connector/grafanacloud connector/servicegraph exporter/loadbalancing exporter/loki Loki Exporter exporter/prometheusremotewrite exporter/splunkhec exporter/sumologic internal/otelarrow internal/tools pkg/stanza processor/deltatocumulative processor/filter Filter processor processor/groupbyattrs Group By Attributes processor processor/groupbytrace Group By Trace processor processor/k8sattributes k8s Attributes processor processor/probabilisticsampler Probabilistic Sampler processor processor/routing Routing processor processor/tailsampling Tail sampling processor receiver/fluentforward receiver/k8scluster receiver/kafka receiver/otlpjsonfile receiver/solace receiver/statsd statsd related issues Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmorel-35 @atoulme @fatsheep9146