[exporter/elasticsearch] [chore] fix lint issues with golangci-lint 1.62 #36798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @TylerHelmuth since you're self-assigned the dependabot PR. |
dmathieu
commented
Dec 12, 2024
carsonip
reviewed
Dec 12, 2024
rockdaboot
reviewed
Dec 12, 2024
|
|
||
| func safeUint64ToInt64(v uint64) int64 { | ||
| if v > math.MaxInt64 { | ||
| return math.MaxInt64 |
There was a problem hiding this comment.
This results in wrong values without notifying the user.
IMO, we can't just silently go on with modified count values here.
Or it needs to documented very well.
There was a problem hiding this comment.
Note that an unchecked overflow will already send wrong values. We're chosing to send the highest maximum value rather than a negative number which would be even more confusing.
I don't mind adding some logging, but I haven't found any such precedent within the package.
And for that log line to be useful and not just cause more noise, we'd have to be able to correlate it to a specific document ID.
dmathieu
force-pushed
the
elasticsearchexporter-gosec
branch
from
5d6437b to
b250f87
Compare
carsonip
reviewed
Dec 12, 2024
carsonip
reviewed
Dec 12, 2024
rockdaboot
reviewed
Dec 12, 2024
rockdaboot
reviewed
Dec 12, 2024
Co-authored-by: Tim Rühsen <[email protected]>
rockdaboot
reviewed
Dec 12, 2024
rockdaboot
reviewed
Dec 12, 2024
rockdaboot
reviewed
Dec 12, 2024
Co-authored-by: Tim Rühsen <[email protected]>
Co-authored-by: Tim Rühsen <[email protected]>
Co-authored-by: Tim Rühsen <[email protected]>
rockdaboot
reviewed
Dec 12, 2024
| @@ -1245,7 +1245,7 @@ func TestEncodeLogBodyMapMode(t *testing.T) { | |||
| resourceLogs := logs.ResourceLogs().AppendEmpty() | |||
| scopeLogs := resourceLogs.ScopeLogs().AppendEmpty() | |||
| logRecords := scopeLogs.LogRecords() | |||
| observedTimestamp := pcommon.Timestamp(time.Now().UnixNano()) | |||
| observedTimestamp := pcommon.Timestamp(time.Now().UnixNano()) // nolint:gosec // UnixNano is positive and thus safe to convert to signed integer. | |||
There was a problem hiding this comment.
Sorry, messed up
Suggested change
| observedTimestamp := pcommon.Timestamp(time.Now().UnixNano()) // nolint:gosec // UnixNano is positive and thus safe to convert to signed integer. | |
| observedTimestamp := pcommon.Timestamp(time.Now().UnixNano()) // nolint:gosec // UnixNano is positive and thus safe to convert to unsigned integer. |
rockdaboot
approved these changes
Dec 12, 2024
carsonip
reviewed
Dec 12, 2024
exporter/elasticsearchexporter/internal/objmodel/objmodel_test.go
Outdated
Show resolved
Hide resolved
carsonip
approved these changes
Dec 12, 2024
Co-authored-by: Christos Markou <[email protected]>
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
….62 (open-telemetry#36798) #### Description The golangci-lint upgrades causes a lot gosec issues due to a new check for integer conversion overflow. This PR checks for integer overflows within the elasticsearch exporter package. #### Link to tracking issue Related: open-telemetry#36638 --------- Co-authored-by: Carson Ip <[email protected]> Co-authored-by: Tim Rühsen <[email protected]> Co-authored-by: Christos Markou <[email protected]>
mterhar
pushed a commit
to mterhar/opentelemetry-collector-contrib
that referenced
this pull request
Dec 19, 2024
….62 (open-telemetry#36798) #### Description The golangci-lint upgrades causes a lot gosec issues due to a new check for integer conversion overflow. This PR checks for integer overflows within the elasticsearch exporter package. #### Link to tracking issue Related: open-telemetry#36638 --------- Co-authored-by: Carson Ip <[email protected]> Co-authored-by: Tim Rühsen <[email protected]> Co-authored-by: Christos Markou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The golangci-lint upgrades causes a lot gosec issues due to a new check for integer conversion overflow.
This PR checks for integer overflows within the elasticsearch exporter package.
Link to tracking issue
Related: #36638