update HttpSemanticConventions for Instrumentation.AspNetCore (part2) #4606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utpilla
approved these changes
Jun 21, 2023
| @@ -3,7 +3,7 @@ | |||
| ## Unreleased | |||
|
|
|||
| * Updated [Http Semantic Conventions](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.21.0/specification/trace/semantic_conventions/http.md). | |||
| * This library can emit either old, new, or both attributes. Users can control | |||
| This library can emit either old, new, or both attributes. Users can control | |||
There was a problem hiding this comment.
I think we should refer to specific version of semantic conventions here. (Needs change before release)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design discussion issue #4484
Follow up to #4537
This PR addresses some leftover comments from the previous PR.
Changes
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes