Fix missing attributes in openai_v2
#3058
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While testing i found out that there were missing attributes not getting set for some reason which are
gen_ai.operation.name
gen_ai.system
gen_ai.request.model
server.address
Type of change
There is an existing util function called
set_span_attributes
which simply takes a dict of attributes and sets the attributes to the span, used this function -- i fear that this is redundant as we already set the span attributes when usingstart_as_current_span
but for some reason which i failed to find out the attributes do not get set unless usingset_span_attributes
-- also the tests were not failing in both scenarios which confused me a bit as well.Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
tox -e py312-test-instrumentation-openai-v2-1
tox -e py312-test-instrumentation-openai-v2-0
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.
Kindly check before & after screenshots