Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing attributes in openai_v2 #3058

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix missing attributes in openai_v2 #3058

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...ntelemetry-instrumentation-openai-v2/src/opentelemetry/instrumentation/openai_v2/patch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
is_streaming,
message_to_event,
set_span_attribute,
set_span_attributes,
)


Expand All @@ -40,14 +41,14 @@ def chat_completions_create(

def traced_method(wrapped, instance, args, kwargs):
span_attributes = {**get_llm_request_attributes(kwargs, instance)}

span_name = f"{span_attributes[GenAIAttributes.GEN_AI_OPERATION_NAME]} {span_attributes[GenAIAttributes.GEN_AI_REQUEST_MODEL]}"
with tracer.start_as_current_span(
name=span_name,
kind=SpanKind.CLIENT,
attributes=span_attributes,
end_on_exit=False,
) as span:
set_span_attributes(span, span_attributes)
if span.is_recording():
for message in kwargs.get("messages", []):
event_logger.emit(
Expand Down Expand Up @@ -90,6 +91,7 @@ async def traced_method(wrapped, instance, args, kwargs):
attributes=span_attributes,
end_on_exit=False,
) as span:
set_span_attributes(span, span_attributes)
if span.is_recording():
for message in kwargs.get("messages", []):
event_logger.emit(
Expand Down
2 changes: 1 addition & 1 deletion ...ntelemetry-instrumentation-openai-v2/src/opentelemetry/instrumentation/openai_v2/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ def choice_to_event(choice, capture_content):


def set_span_attributes(span, attributes: dict):
for field, value in attributes.model_dump(by_alias=True).items():
for field, value in attributes.items():
set_span_attribute(span, field, value)


Expand Down
Loading