Skip to content

Commit

Permalink
Refine Dynamic Evaluation in LoggerConfig
Browse files Browse the repository at this point in the history
  • Loading branch information
pellared committed Jan 9, 2025
1 parent 1a9ad31 commit 170fb68
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions oteps/logs/4290-logger-enabled.md
Original file line number Diff line number Diff line change
Expand Up @@ -237,14 +237,13 @@ There is a [proposal](https://github.com/open-telemetry/opentelemetry-specificat
suggested dynamic evaluation in `LoggerConfig` instead of static configuration
to make the `LoggerConfig` to support dynamic evaluation.

However, since the purpose of `LoggerConfig` is static configuration,
and use cases (5) and (6) are tied to log record processing,
extending `LogRecordProcessor` seem more appropriate.

Additionally, nothing prevents adding some other way of configuring Loggers similar to
[Metrics View](../../specification/metrics/sdk.md#view).
This was proposed [here](https://github.com/open-telemetry/opentelemetry-specification/pull/4290#discussion_r1908897211).

It is worth mentioning that the purpose of `LoggerConfig` is `Logger` configuration.
It won't solve use cases (5) and (6) that are tied to log processing pipelines.

### Extending Logger.Enabled

The `Enabled` API could be extended in the future
Expand Down

0 comments on commit 170fb68

Please sign in to comment.