Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/otel/trace/arrow: Set parentSpanID NULL if empty bytes #273

Merged
merged 3 commits into from
Nov 19, 2024
Merged

pkg/otel/trace/arrow: Set parentSpanID NULL if empty bytes #273

merged 3 commits into from
Nov 19, 2024

Conversation

metalmatze
Copy link
Contributor

Fixes #272

@metalmatze
Copy link
Contributor Author

I had some time on the flight to KubeCon, @lquerel.
Greetings from above Lake Winnipeg. 😃

lquerel
lquerel approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@lquerel lquerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and it was cool to be able to meet you in person at KubeCon!

@lquerel lquerel merged commit a116deb into open-telemetry:main Nov 19, 2024
2 checks passed
@jmacd jmacd mentioned this pull request Nov 19, 2024
Merged
jmacd added a commit that referenced this pull request Nov 19, 2024
@jmacd
Release v0.31.0 (#275)
4ad461c 
- Update to v0.114.0 collector dependencies.
[#274](#274)
- Empty SpanID bug-fix.
[#273](#273)
@metalmatze metalmatze deleted the traces-parentspanid-null branch November 27, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lquerel lquerel lquerel approved these changes

@jmacd jmacd Awaiting requested review from jmacd jmacd is a code owner

@moh-osman3 moh-osman3 Awaiting requested review from moh-osman3 moh-osman3 is a code owner

@codeboten codeboten Awaiting requested review from codeboten codeboten is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

parent_span_id must be set to null when not defined in the OTLP message
2 participants
@metalmatze @lquerel