Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent the linktobranch command to work when there is no @package #17315

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Prevent the linktobranch command to work when there is no @package #17315

wants to merge 1 commit into from

Conversation

danidoni
Copy link
Contributor

@danidoni danidoni commented Jan 29, 2025 •
edited
Loading

When the package name is _pattern the code does not set the @package variable. So we need to avoid calling the command if we have no package to work on.

Fixes #17305

@github-actions github-actions bot added the Frontend Things related to the OBS RoR app label Jan 29, 2025
@danidoni danidoni force-pushed the fix-undefined-method-project-when-executing-a-linktobranch-command-against-a-pattern-file branch from 4e847ae to 07a74a8 Compare January 29, 2025 16:44
@danidoni danidoni changed the title WIP Prevent the linktobranch command to work when there is no @package Jan 29, 2025
@danidoni danidoni force-pushed the fix-undefined-method-project-when-executing-a-linktobranch-command-against-a-pattern-file branch 2 times, most recently from 4332b4e to 0500eac Compare January 30, 2025 10:23
@danidoni danidoni marked this pull request as ready for review January 30, 2025 10:24
@danidoni danidoni force-pushed the fix-undefined-method-project-when-executing-a-linktobranch-command-against-a-pattern-file branch from 0500eac to ad3afcf Compare January 30, 2025 14:52
@danidoni danidoni force-pushed the fix-undefined-method-project-when-executing-a-linktobranch-command-against-a-pattern-file branch from 4d59d0b to b6a72ed Compare February 3, 2025 15:35
@danidoni danidoni force-pushed the fix-undefined-method-project-when-executing-a-linktobranch-command-against-a-pattern-file branch from b6a72ed to 69c9aea Compare February 3, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hennevogel hennevogel hennevogel left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Frontend Things related to the OBS RoR app
Projects
None yet
Milestone
No milestone
2 participants
@danidoni @hennevogel