Make the BsRequestAction target nullification simpler #17347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hennevogel
reviewed
Feb 6, 2025
src/api/db/data/20250131094818_nullify_targets_on_bs_request_actions.rb
Outdated
Show resolved
Hide resolved
src/api/db/data/20250131094818_nullify_targets_on_bs_request_actions.rb
Outdated
Show resolved
Hide resolved
eduardoj
reviewed
Feb 6, 2025
src/api/db/data/20250131094818_nullify_targets_on_bs_request_actions.rb
Outdated
Show resolved
Hide resolved
eduardoj
reviewed
Feb 6, 2025
src/api/db/data/20250131094818_nullify_targets_on_bs_request_actions.rb
Outdated
Show resolved
Hide resolved
danidoni
force-pushed
the
make-the-bs-request-actions-target-nullification-simpler
branch
2 times, most recently
from
b973320 to
2c3f536
Compare
danidoni
force-pushed
the
make-the-bs-request-actions-target-nullification-simpler
branch
from
2c3f536 to
b8a1de0
Compare
eduardoj
approved these changes
Feb 6, 2025
src/api/db/data/20250131094818_nullify_targets_on_bs_request_actions.rb
Outdated
Show resolved
Hide resolved
danidoni
force-pushed
the
make-the-bs-request-actions-target-nullification-simpler
branch
from
b8a1de0 to
b56cc27
Compare
We use left joins to make the script simpler and hopefully faster.
danidoni
force-pushed
the
make-the-bs-request-actions-target-nullification-simpler
branch
from
b56cc27 to
91ea29b
Compare
danidoni
deleted the
make-the-bs-request-actions-target-nullification-simpler
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use left joins to make the script simpler and hopefully faster.
This statement should tell us if the data migration is working, as it should decrease as it runs: