Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the BsRequestAction target nullification simpler #17347

Merged
merged 1 commit into from
Feb 6, 2025
+8 −24
Merged

Make the BsRequestAction target nullification simpler #17347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 8 additions & 24 deletions src/api/db/data/20250131094818_nullify_targets_on_bs_request_actions.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,31 +3,15 @@
class NullifyTargetsOnBsRequestActions < ActiveRecord::Migration[7.0]
# rubocop:disable Rails/SkipsModelValidations
def up
bs_request_actions = BsRequestAction.where('target_project_id IS NOT NULL AND target_package_id IS NULL')
bs_request_actions.in_batches do |batch|
batch.find_each do |action|
target_project = Project.find_by(name: action.target_project)
if target_project.nil?
action.update_columns(target_project_id: nil)
end
end
end
BsRequestAction
.joins('LEFT JOIN projects ON bs_request_actions.target_project_id = projects.id WHERE bs_request_actions.target_project_id IS NOT NULL AND projects.id IS NULL')
.in_batches
.update_all(target_project_id: nil)

bs_request_actions = BsRequestAction.where('target_project_id IS NOT NULL AND target_package_id IS NOT NULL')
bs_request_actions.in_batches do |batch|
batch.find_each do |action|
target_project = Project.find_by(name: action.target_project)
if target_project.nil?
action.update_columns(target_project_id: nil, target_package_id: nil)
next
end

target_package = Package.find_by_project_and_name(action.target_project, action.target_package)
if target_package.nil?
action.update_columns(target_package_id: nil)
end
end
end
BsRequestAction
.joins('LEFT JOIN packages ON bs_request_actions.target_package_id = packages.id WHERE bs_request_actions.target_package_id IS NOT NULL AND packages.id IS NULL')
.in_batches
.update_all(target_package_id: nil)
end
# rubocop:enable Rails/SkipsModelValidations

Expand Down