New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding AFT Base cases #3506

Merged

dplore merged 39 commits into openconfig:main from sudhinj:main

Nov 15, 2024

Contributor

sudhinj commented Oct 10, 2024

This includes the test cases for validating AFT Base path.

sudhinj added 7 commits

October 7, 2024 06:15


          adding a new id by sudhin

cff9734


          adding aft

e755346


          removing files

e66be74


          adding readme

f1c90b7


          adding test cases

d6f52a7


          modify

be46d35


          Merge branch 'openconfig:main' into main

d7d7481

sudhinj requested a review from a team as a code owner

October 10, 2024 04:35

OpenConfigBot commented Oct 10, 2024 •

edited

Loading

Pull Request Functional Test Report for #3506 / `79b29ff`

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		RT-4.10: AFTs Route Summary RT-4.11: AFTs Route Summary
Cisco 8000E		RT-4.10: AFTs Route Summary RT-4.11: AFTs Route Summary
Cisco XRd		RT-4.10: AFTs Route Summary RT-4.11: AFTs Route Summary
Juniper ncPTX		RT-4.10: AFTs Route Summary RT-4.11: AFTs Route Summary
Nokia SR Linux		RT-4.10: AFTs Route Summary RT-4.11: AFTs Route Summary
Openconfig Lemming		RT-4.10: AFTs Route Summary RT-4.11: AFTs Route Summary

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		RT-4.10: AFTs Route Summary RT-4.11: AFTs Route Summary
Cisco 8808		RT-4.10: AFTs Route Summary RT-4.11: AFTs Route Summary
Juniper PTX10008		RT-4.10: AFTs Route Summary RT-4.11: AFTs Route Summary
Nokia 7250 IXR-10e		RT-4.10: AFTs Route Summary RT-4.11: AFTs Route Summary

coveralls commented Oct 10, 2024 •

edited

Loading

Pull Request Test Coverage Report for Build 11860715541

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.268%

Totals
Change from base Build 11559676696:	0.0%
Covered Lines:	1983
Relevant Lines:	3588

💛 - Coveralls

sudhinj added 3 commits

October 10, 2024 04:43


          removing faulty oc

6f1c043


          adding test cases for prefix counters

ce1275b


          adding test case numbers

910c66b

dplore assigned ElodinLaarz

Member

dplore commented Oct 10, 2024

@ElodinLaarz can you review please?

ElodinLaarz reviewed

View reviewed changes

Contributor

ElodinLaarz left a comment

Did a first pass on the READMEs. Thanks for writing these up :)

feature/aft/aft_base/otg_tests/aft_base/README.md Outdated Show resolved Hide resolved

feature/aft/aft_base/otg_tests/aft_base/README.md Outdated Show resolved Hide resolved

feature/aft/aft_base/otg_tests/aft_base/README.md Outdated Show resolved Hide resolved

feature/aft/aft_base/otg_tests/aft_base/README.md Outdated Show resolved Hide resolved

feature/aft/aft_base/otg_tests/aft_base/README.md Outdated Show resolved Hide resolved

feature/aft/aft_base/otg_tests/aft_base/README.md Outdated Show resolved Hide resolved

feature/aft/aft_base/otg_tests/aft_prefixcounters/README.md Outdated Show resolved Hide resolved

feature/aft/aft_base/otg_tests/aft_prefixcounters/README.md Outdated Show resolved Hide resolved

feature/aft/aft_base/otg_tests/aft_prefixcounters/README.md Outdated Show resolved Hide resolved

dplore reviewed

View reviewed changes

feature/aft/aft_base/otg_tests/aft_base/README.md Outdated Show resolved Hide resolved

feature/aft/aft_base/otg_tests/aft_base/README.md Outdated Show resolved Hide resolved

feature/aft/aft_base/otg_tests/aft_base/README.md Outdated Show resolved Hide resolved

feature/aft/aft_base/otg_tests/aft_base/README.md Outdated Show resolved Hide resolved

sudhinj added 9 commits

October 16, 2024 05:27


          updating the changes

5f47ede


          adding comments for pull request


          Merge branch 'main' into main

a08b48f


          added comments

b609c03


          Merge branch 'main' of github.com:sudhinj/featureprofiles

cc42810


          Merge branch 'openconfig:main' into main

fc255ee


          Merge branch 'openconfig:main' into main

e37574e


          adding the comments

e476a0a


          Merge branch 'main' of github.com:sudhinj/featureprofiles

d89eb06

sudhinj requested a review from ram-mac

October 29, 2024 08:05

ram-mac previously approved these changes

View reviewed changes

Contributor

ram-mac left a comment

LGTM to me


          adding the comments

sudhinj dismissed ram-mac’s stale review via

October 29, 2024 08:08

dplore requested changes

View reviewed changes

feature/aft/aft_base/otg_tests/aft_base/README.md Outdated Show resolved Hide resolved

feature/aft/aft_base/otg_tests/aft_base/README.md Outdated Show resolved Hide resolved

feature/aft/aft_base/otg_tests/aft_base/README.md Outdated Show resolved Hide resolved

feature/aft/aft_base/otg_tests/aft_base/README.md Outdated Show resolved Hide resolved

feature/aft/aft_base/otg_tests/aft_base/README.md Outdated Show resolved Hide resolved

feature/aft/aft_base/otg_tests/aft_prefixcounters/README.md Outdated Show resolved Hide resolved

feature/aft/aft_base/otg_tests/aft_prefixcounters/README.md Outdated Show resolved Hide resolved

feature/aft/aft_base/otg_tests/aft_prefixcounters/README.md Outdated Show resolved Hide resolved

feature/aft/aft_base/otg_tests/aft_prefixcounters/README.md Outdated Show resolved Hide resolved

feature/aft/aft_base/otg_tests/aft_prefixcounters/README.md Outdated Show resolved Hide resolved


          latest updates

8e00c94

sudhinj dismissed ram-mac’s stale review via

8e00c94

October 30, 2024 06:22

dplore reviewed

View reviewed changes

Member

dplore left a comment

Almost there!

feature/aft/aft_base/otg_tests/aft_base/README.md Outdated Show resolved Hide resolved

feature/aft/aft_base/otg_tests/aft_prefixcounters/README.md Outdated Show resolved Hide resolved

sudhinj added 2 commits

November 12, 2024 04:37


          adding test bed topology

f6f8591


          adding test bed topology

8ef4a58

dplore previously approved these changes

View reviewed changes


          adding scale test multi protocol dual stack for aft summary

e8c73df

sudhinj dismissed dplore’s stale review via

e8c73df

November 12, 2024 11:39

sudhinj added 8 commits

November 12, 2024 11:44


          corrections

dce47ea

add

493902d

add

5f886d4

fix

c59fa14

fix

630d308

new

d0fcf93


          new fix

a7c89ae


          new fix

yunjie-lu reviewed

View reviewed changes

feature/aft/aft_base/otg_tests/aft_prefixcounters/README.md Outdated Show resolved Hide resolved

yunjie-lu requested changes

View reviewed changes

yunjie-lu left a comment •

edited

Loading

Could you update the file paths to match the featureprofileids? I.e.,
"afts_base"
"afts_prefix_counters"
"afts_summary"

yunjie-lu requested changes

View reviewed changes

yunjie-lu left a comment •

edited

Loading

Could you update the file paths to match the featureprofileids? I.e.,
"afts_base"
"afts_prefix_counters"
"afts_summary"

feature/aft/aft_base/otg_tests/aft_base/README.md Outdated Show resolved Hide resolved

testregistry.textproto Show resolved Hide resolved

feature/aft/aft_summary/otg_tests/scale_aft_summary/metadata.textproto Outdated Show resolved Hide resolved

Member

dplore commented Nov 15, 2024

/fptest all


          changes

44ad581

yunjie-lu commented Nov 15, 2024

Could you update the file paths to match the featureprofileids? I.e., "afts_base" "afts_prefix_counters" "afts_summary"

Could you fix this? Otherwise LGTM.

sudhinj added 2 commits

November 15, 2024 17:26


          correction folder

4bba7f5


          folder name change

79b29ff

yunjie-lu approved these changes

View reviewed changes

dplore approved these changes

View reviewed changes

dplore merged commit 5e2b2f2 into openconfig:main

13 checks passed

mastarkey pushed a commit to b4firex/featureprofiles that referenced this pull request


          Adding AFT Base cases (openconfig#3506)

18eb177

Add AFT-1.1
Add AFT-2.1
Update RT-4.11

ANISH-GOTTAPU pushed a commit to open-traffic-generator/featureprofiles that referenced this pull request


          Adding AFT Base cases (openconfig#3506)

39235f8

Add AFT-1.1
Add AFT-2.1
Update RT-4.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet