[Issue:3569] Do better about reaching into proto structs. #3570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not reach into a snake pit without first checking if snakes in pit! Patterns like: ``` pb "myprotofile" ... var f pb.Foo snakesBhere := f.THINGS.N.Snakes ``` get you a panic(). Let's not do that, ok?
Pull Request Test Coverage Report for Build 11741787385Details
💛 - Coveralls |
robshakir
approved these changes
Nov 8, 2024
ANISH-GOTTAPU
pushed a commit
to open-traffic-generator/featureprofiles
that referenced
this pull request
Nov 28, 2024
…#3570) Do not reach into a snake pit without first checking if snakes in pit! Patterns like: ``` pb "myprotofile" ... var f pb.Foo snakesBhere := f.THINGS.N.Snakes ``` get you a panic(). Let's not do that, ok?
alshabib
pushed a commit
to alshabib/featureprofiles
that referenced
this pull request
Jan 19, 2025
…#3570) Do not reach into a snake pit without first checking if snakes in pit! Patterns like: ``` pb "myprotofile" ... var f pb.Foo snakesBhere := f.THINGS.N.Snakes ``` get you a panic(). Let's not do that, ok?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not reach into a snake pit without first checking if snakes in pit! Patterns like:
get you a panic().
Let's not do that, ok?