Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QoS Prioritization of Egress Traffic Test README.md #3666

Closed
wants to merge 1 commit into from

Conversation

rahulsy26
Copy link
Contributor

As this test is written for NCS5K DUT which is not fully OC Compliance and using GNMICli for configuration and telemetry. thats why OC path is not mention in README.md

@rahulsy26 rahulsy26 requested a review from trlongth December 20, 2024 08:33
@rahulsy26 rahulsy26 requested a review from sezhang2 as a code owner December 20, 2024 08:33
@OpenConfigBot
Copy link

OpenConfigBot commented Dec 20, 2024

Pull Request Functional Test Report for #3666 / f56ac1c

No tests identified for validation.

Help

@rahulsy26 rahulsy26 force-pushed the egress_traffic_prioritize_mpls_exp_test branch from d6ef4af to f56ac1c Compare December 20, 2024 08:37
@coveralls
Copy link

coveralls commented Dec 20, 2024

Pull Request Test Coverage Report for Build 12428211107

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.268%

Totals Coverage Status
Change from base Build 12419317171: 0.0%
Covered Lines: 1983
Relevant Lines: 3588

💛 - Coveralls

@rahulsy26 rahulsy26 changed the title Adding a new README.md for QoS test QoS Prioritization of Egress Traffic Test README.md Dec 23, 2024
@robshakir
Copy link
Contributor

Tests here should not be scoped to a single platform -- and should generally use OpenConfig with deviations for vendor-specific config to accommodate non-compliant platforms. Please discuss with @rohit-rp.


No changes in DSCP marking and TTL when policy is applied to bundle interface

* Apply policy number 3.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is policy number 3.4?

Copy link
Contributor

@sezhang2 sezhang2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this test written for a specific platform?

@rahulsy26
Copy link
Contributor Author

Closing this PR as this test is going to commit on google3.

@rahulsy26 rahulsy26 closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants