[containerz]: make image_size required #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow the server to end the RPC gracefully if there is not enough space to receive the incoming image.
Pull Request Test Coverage Report for Build 12276497170Details
💛 - Coveralls |
|
staticcheck is failing for unrelated reasons: All generated Can this staticcheck job be overridden? |
|
Hi @brianneville -- can you pull |
|
Assigning review to @alshabib -- thanks Ali :-) |
alshabib
reviewed
Dec 14, 2024
| @@ -140,7 +140,9 @@ message ImageTransfer { | |||
| // container image. | |||
| string tag = 2; | |||
|
|
|||
| // Optional. Indicates the size (in bytes) of the container image. | |||
| // Indicates the size (in bytes) of the container image. | |||
| // Required to allow the server should validate that there | |||
There was a problem hiding this comment.
Replace server with target for consistency with the rest of this doc.
There was a problem hiding this comment.
Can you sync and re-kick the tests?
alshabib
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow the server to end the RPC gracefully if there is not enough space to receive the incoming image.