Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[containerz]: make image_size required #230

Merged
merged 1 commit into from
Jan 13, 2025
Merged

[containerz]: make image_size required #230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion containerz/containerz.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,9 @@ message ImageTransfer {
// container image.
string tag = 2;

// Optional. Indicates the size (in bytes) of the container image.
// Indicates the size (in bytes) of the container image.
// Required to allow the server should validate that there
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace server with target for consistency with the rest of this doc.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you sync and re-kick the tests?

// is enough space to receive the incoming image.
uint64 image_size = 3;

// Optional. Instructs the target to fetch the image from a remote location.
Expand Down
Loading