Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bulk remove and implement more remove RPC #436

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Bulk remove and implement more remove RPC #436

merged 3 commits into from
Jun 17, 2024

Conversation

DanG100
Copy link
Collaborator

@DanG100 DanG100 commented Jun 17, 2024

No description provided.

@DanG100 DanG100 requested a review from guoshiuan June 17, 2024 16:42
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9551489993

Details

  • 24 of 67 (35.82%) changed or added relevant lines in 4 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.002%) to 2.806%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/saiserver/policer.go 0 10 0.0%
dataplane/apigen/protogen/protogen.go 0 11 0.0%
dataplane/saiserver/routing.go 21 43 48.84%
Files with Coverage Reduction New Missed Lines %
dataplane/saiserver/policer.go 1 38.1%
bgp/gobgp.go 2 41.76%
Totals Coverage Status
Change from base Build 9551424572: 0.002%
Covered Lines: 18467
Relevant Lines: 658105
💛 - Coveralls

1 similar comment
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9551489993

Details

  • 24 of 67 (35.82%) changed or added relevant lines in 4 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.002%) to 2.806%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/saiserver/policer.go 0 10 0.0%
dataplane/apigen/protogen/protogen.go 0 11 0.0%
dataplane/saiserver/routing.go 21 43 48.84%
Files with Coverage Reduction New Missed Lines %
dataplane/saiserver/policer.go 1 38.1%
bgp/gobgp.go 2 41.76%
Totals Coverage Status
Change from base Build 9551424572: 0.002%
Covered Lines: 18467
Relevant Lines: 658105
💛 - Coveralls

@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9551485183

Details

  • 24 of 67 (35.82%) changed or added relevant lines in 4 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.002%) to 2.806%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/saiserver/policer.go 0 10 0.0%
dataplane/apigen/protogen/protogen.go 0 11 0.0%
dataplane/saiserver/routing.go 21 43 48.84%
Files with Coverage Reduction New Missed Lines %
dataplane/saiserver/policer.go 1 38.1%
bgp/gobgp.go 2 41.76%
Totals Coverage Status
Change from base Build 9551424572: 0.002%
Covered Lines: 18467
Relevant Lines: 658105
💛 - Coveralls

@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9551489993

Details

  • 24 of 67 (35.82%) changed or added relevant lines in 4 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.002%) to 2.806%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/saiserver/policer.go 0 10 0.0%
dataplane/apigen/protogen/protogen.go 0 11 0.0%
dataplane/saiserver/routing.go 21 43 48.84%
Files with Coverage Reduction New Missed Lines %
dataplane/saiserver/policer.go 1 38.1%
bgp/gobgp.go 2 41.76%
Totals Coverage Status
Change from base Build 9551424572: 0.002%
Covered Lines: 18467
Relevant Lines: 658105
💛 - Coveralls

@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9551485183

Details

  • 24 of 67 (35.82%) changed or added relevant lines in 4 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.002%) to 2.806%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/saiserver/policer.go 0 10 0.0%
dataplane/apigen/protogen/protogen.go 0 11 0.0%
dataplane/saiserver/routing.go 21 43 48.84%
Files with Coverage Reduction New Missed Lines %
dataplane/saiserver/policer.go 1 38.1%
bgp/gobgp.go 2 41.76%
Totals Coverage Status
Change from base Build 9551424572: 0.002%
Covered Lines: 18467
Relevant Lines: 658105
💛 - Coveralls

1 similar comment
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9551485183

Details

  • 24 of 67 (35.82%) changed or added relevant lines in 4 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.002%) to 2.806%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/saiserver/policer.go 0 10 0.0%
dataplane/apigen/protogen/protogen.go 0 11 0.0%
dataplane/saiserver/routing.go 21 43 48.84%
Files with Coverage Reduction New Missed Lines %
dataplane/saiserver/policer.go 1 38.1%
bgp/gobgp.go 2 41.76%
Totals Coverage Status
Change from base Build 9551424572: 0.002%
Covered Lines: 18467
Relevant Lines: 658105
💛 - Coveralls

@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9551626891

Details

  • 24 of 67 (35.82%) changed or added relevant lines in 4 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.002%) to 2.806%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/saiserver/policer.go 0 10 0.0%
dataplane/apigen/protogen/protogen.go 0 11 0.0%
dataplane/saiserver/routing.go 21 43 48.84%
Files with Coverage Reduction New Missed Lines %
dataplane/saiserver/policer.go 1 38.1%
bgp/gobgp.go 2 41.76%
Totals Coverage Status
Change from base Build 9551424572: 0.002%
Covered Lines: 18467
Relevant Lines: 658105
💛 - Coveralls

2 similar comments
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9551626891

Details

  • 24 of 67 (35.82%) changed or added relevant lines in 4 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.002%) to 2.806%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/saiserver/policer.go 0 10 0.0%
dataplane/apigen/protogen/protogen.go 0 11 0.0%
dataplane/saiserver/routing.go 21 43 48.84%
Files with Coverage Reduction New Missed Lines %
dataplane/saiserver/policer.go 1 38.1%
bgp/gobgp.go 2 41.76%
Totals Coverage Status
Change from base Build 9551424572: 0.002%
Covered Lines: 18467
Relevant Lines: 658105
💛 - Coveralls

@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 9551626891

Details

  • 24 of 67 (35.82%) changed or added relevant lines in 4 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.002%) to 2.806%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/saiserver/policer.go 0 10 0.0%
dataplane/apigen/protogen/protogen.go 0 11 0.0%
dataplane/saiserver/routing.go 21 43 48.84%
Files with Coverage Reduction New Missed Lines %
dataplane/saiserver/policer.go 1 38.1%
bgp/gobgp.go 2 41.76%
Totals Coverage Status
Change from base Build 9551424572: 0.002%
Covered Lines: 18467
Relevant Lines: 658105
💛 - Coveralls

@DanG100 DanG100 merged commit 2b57113 into main Jun 17, 2024
10 of 11 checks passed
@DanG100 DanG100 deleted the bulk-rem branch June 17, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guoshiuan guoshiuan guoshiuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanG100 @guoshiuan