Bulk remove and implement more remove RPC

dataplane/apigen/ccgen/ccgen.go

@@ -200,6 +200,18 @@ func createCCData(meta *saiast.FuncMetadata, apiName string, sai *saiast.SAIAPI,
 			}
 			smt.EnumValue = attr.EnumName
 		}
+	case "remove_bulk":
+		convertFn = nil
+		opFn.EntryVar = strings.TrimPrefix(opFn.EntryVar, "*") // Usual entry is pointer, but for remove_bulk it's an array.
+		for _, attr := range info.Attrs[meta.TypeName].CreateFields {
+			name := sanitizeProtoName(attr.MemberName)
+			smt, err := protoFieldSetter(attr.SaiType, "", name, "attr_list[i].value", info)
+			if err != nil {
+				fmt.Println("skipping due to error: ", err)
+				continue
+			}
+			smt.EnumValue = attr.EnumName
+		}
 	case "get_stats":
 		convertFn = nil
 		opFn.AttrEnumType = strcase.UpperCamelCase(meta.TypeName + " stat")
@@ -487,7 +499,7 @@ var supportedOperation = map[string]bool{
 	"get_stats":          true,
 	"get_stats_ext":      true,
 	"create_bulk":        true,
-	"remove_bulk":        false,
+	"remove_bulk":        true,
 	"set_attribute_bulk": false,
 	"get_attribute_bulk": false,
 }
@@ -524,7 +536,7 @@ extern const {{ .APIType }} l_{{ .APIName }};
 #endif  // {{ .IncludeGuard }}
 `))
 	ccTmpl = template.Must(template.New("cc").Parse(`
-{{ define "getattr" }}
+{{- define "getattr" }}
 {{ $parent := . }}
 switch ({{ .Var }}) {
   {{ range .Attrs }}
@@ -546,7 +558,7 @@ switch ({{ .Var }}) {
  {{- end }}
 }
 {{ end }}
-{{ define "setattr" }}
+{{- define "setattr" }}
 {{ $parent := . }}
 switch ({{ .Var }}) {
   {{ range .Attrs }}
@@ -562,9 +574,7 @@ switch ({{ .Var }}) {
 	break;
  {{- end }}
 }
-{{ end }}
-
-
+{{ end -}}
 // Copyright 2023 Google LLC
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
@@ -701,6 +711,27 @@ return msg;
 		LOG(ERROR) << status.error_message();
 		return SAI_STATUS_FAILURE;
 	}
+	{{ else if eq .Operation "remove_bulk" }}
+	lemming::dataplane::sai::{{ .ReqType }} req;
+	lemming::dataplane::sai::{{ .RespType }} resp;
+	grpc::ClientContext context;
+
+	for (uint32_t i = 0; i < object_count; i++) {
+		{{ if .OidVar -}} req.add_reqs()->set_oid(object_id[i]); {{ end }}
+		{{ if .EntryVar }} *req.add_reqs()->mutable_entry() = {{ .EntryConversionFunc }}({{ .EntryVar }}[i]); {{ end }}
+	}
+
+	grpc::Status status = {{ .Client }}->{{ .RPCMethod }}(&context, req, &resp);
+	if (!status.ok()) {
+		LOG(ERROR) << status.error_message();
+		return SAI_STATUS_FAILURE;
+	}
+	if (object_count != resp.resps().size()) {
+		return SAI_STATUS_FAILURE;
+	}
+	for (uint32_t i = 0; i < object_count; i++) {
+		object_statuses[i] = SAI_STATUS_SUCCESS;
+	}
 	{{ else if eq .Operation "get_stats" }}
 	lemming::dataplane::sai::{{ .ReqType }} req;
 	lemming::dataplane::sai::{{ .RespType }} resp;

dataplane/apigen/protogen/protogen.go

@@ -274,6 +274,17 @@ func populateTmplDataFromFunc(apis map[string]*protoAPITmplData, docInfo *docpar
 			ProtoType: repeatedType + strcase.UpperCamelCase("Create "+meta.TypeName+"Response"),
 			Index:     1,
 		})
+	case "remove_bulk":
+		req.Fields = append(req.Fields, protoTmplField{
+			Name:      "reqs",
+			ProtoType: repeatedType + strcase.UpperCamelCase("Remove "+meta.TypeName+"Request"),
+			Index:     1,
+		})
+		resp.Fields = append(resp.Fields, protoTmplField{
+			Name:      "resps",
+			ProtoType: repeatedType + strcase.UpperCamelCase("Remove "+meta.TypeName+"Response"),
+			Index:     1,
+		})
 	case "get_stats":
 		req.Fields = append(req.Fields, idField, protoTmplField{
 			Name:      "counter_ids",

dataplane/proto/sai/fdb.proto

@@ -71,6 +71,14 @@ message CreateFdbEntriesResponse {
   repeated CreateFdbEntryResponse resps = 1;
 }
 
+message RemoveFdbEntriesRequest {
+  repeated RemoveFdbEntryRequest reqs = 1;
+}
+
+message RemoveFdbEntriesResponse {
+  repeated RemoveFdbEntryResponse resps = 1;
+}
+
 service Fdb {
   rpc CreateFdbEntry(CreateFdbEntryRequest) returns (CreateFdbEntryResponse) {}
   rpc RemoveFdbEntry(RemoveFdbEntryRequest) returns (RemoveFdbEntryResponse) {}
@@ -80,4 +88,6 @@ service Fdb {
       returns (GetFdbEntryAttributeResponse) {}
   rpc CreateFdbEntries(CreateFdbEntriesRequest)
       returns (CreateFdbEntriesResponse) {}
+  rpc RemoveFdbEntries(RemoveFdbEntriesRequest)
+      returns (RemoveFdbEntriesResponse) {}
 }

dataplane/proto/sai/lag.proto

@@ -120,6 +120,14 @@ message CreateLagMembersResponse {
   repeated CreateLagMemberResponse resps = 1;
 }
 
+message RemoveLagMembersRequest {
+  repeated RemoveLagMemberRequest reqs = 1;
+}
+
+message RemoveLagMembersResponse {
+  repeated RemoveLagMemberResponse resps = 1;
+}
+
 service Lag {
   rpc CreateLag(CreateLagRequest) returns (CreateLagResponse) {}
   rpc RemoveLag(RemoveLagRequest) returns (RemoveLagResponse) {}
@@ -137,4 +145,6 @@ service Lag {
       returns (GetLagMemberAttributeResponse) {}
   rpc CreateLagMembers(CreateLagMembersRequest)
       returns (CreateLagMembersResponse) {}
+  rpc RemoveLagMembers(RemoveLagMembersRequest)
+      returns (RemoveLagMembersResponse) {}
 }