Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: course mode added to the metadata #33691

Conversation

Inferato
Copy link
Contributor

@Inferato Inferato commented Nov 9, 2023

Description

This is a backport MR to the master branch.

According to the chapter Sending Email Messages to Learners in Different Enrollment Tracks course can may more than one mode and instructor must have the ability to send the email for users in this modes.
Communication MFE had a hardcoded 2 modes for every course. Sometimes it lead to the error.
изображение

courseModes was added to courseMetadata to display real course email recipient options.

Related MR:

Deadline

None

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 9, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @Inferato! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mariajgrimaldi
Copy link
Member

Hi there @Inferato! We usually backport PR(s) after their corresponding master PR is merged. So we'll review this contribution against quince.master once that happens. Thanks!

@cmltaWt0 cmltaWt0 added the product review PR requires product review before merging label Feb 6, 2024
@dyudyunov
Copy link
Contributor

dyudyunov commented Feb 7, 2024

Just for history:
Related PR for the Communications MFE was reopened: openedx/frontend-app-communications#192

@cmltaWt0 cmltaWt0 removed the product review PR requires product review before merging label Feb 8, 2024
@feanil feanil merged commit b679152 into openedx:open-release/quince.master Feb 29, 2024
43 checks passed
@openedx-webhooks
Copy link

@Inferato 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants