-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Course mode is used to show the correct bulk email options #172
fix: Course mode is used to show the correct bulk email options #172
Conversation
Thanks for the pull request, @Inferato! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## open-release/quince.master #172 +/- ##
=============================================================
Coverage ? 83.18%
=============================================================
Files ? 47
Lines ? 690
Branches ? 135
=============================================================
Hits ? 574
Misses ? 116
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Isn't this the same as #171? |
@arbrandes: it looks like it, but this is the backport PR |
This PR should be closed in favor of #192. The only difference compared to the current PR is that I applied Adolfo's suggestions from the master PR |
Got it. Would you mind adding the same description to the new PR? |
Ok, but I would rather copy the description from the related master PR #191 |
@Inferato Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This is a backport MR to the master branch.
According to the chapter Sending Email Messages to Learners in Different Enrollment Tracks course can may more than one mode and instructor must have the ability to send the email for users in this modes.

Communication MFE had a hardcoded 2 modes for every course. Sometimes it lead to the error.
courseModes
was added tocourseMetadata
to display real course email recipient options.Related MR: