Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Use Locator property block_id. #34187

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Fix: Use Locator property block_id. #34187

merged 1 commit into from
Mar 18, 2024

Conversation

lewisemm
Copy link
Contributor

@lewisemm lewisemm commented Feb 6, 2024

Description

This change has been made to address 9 deprecation warnings which can be seen after the tests are run.

name property of Locators has been deprecated and replaced by the block_id property.

Supporting information

Fixes openedx/public-engineering#156.

This PR also replaces #34087 which was accidentally overwritten and closed while working on a separate issue.

Testing instructions

Nine messages from this deprecation warning were being displayed after tests in the cms-2 shard were run.

With this change, the nine deprecation warnings have been addressed.

This can be tested manually by running unit tests on the cms-2 shard.

python -Wd -m pytest -p no:randomly --ds=cms.envs.test cms/djangoapps/contentstore/

Deadline

"None" if there's no rush, or provide a specific date or event (and reason) if there is one.

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.
  • If your database migration can't be rolled back easily.

@openedx-webhooks
Copy link

Thanks for the pull request, @lewisemm! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 6, 2024
@lewisemm lewisemm force-pushed the issue-156-name-not-supported branch from 34494ba to 2eaac10 Compare February 6, 2024 07:52
@lewisemm
fix: Use Locator property block_id.
65e244e 
This change has been made to address 9 deprecation warnings which
can be seen after the tests are run.

`name` property of Locators has been deprecated and replaced by the
`block_id` property.
@lewisemm lewisemm force-pushed the issue-156-name-not-supported branch from 2eaac10 to 65e244e Compare February 6, 2024 17:57
@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Feb 21, 2024
bradenmacdonald
bradenmacdonald approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - thanks for fixing this, @lewisemm !

@bradenmacdonald bradenmacdonald merged commit 3a84339 into openedx:master Mar 18, 2024
46 checks passed
@openedx-webhooks
Copy link

@lewisemm 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@lewisemm lewisemm deleted the issue-156-name-not-supported branch March 18, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradenmacdonald bradenmacdonald bradenmacdonald approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U waiting for eng review PR is ready for review. Review and merge it, or suggest changes.
Projects
Contributions
Archived in project
Milestone
No milestone
5 participants
@lewisemm @openedx-webhooks @edx-pipeline-bot @bradenmacdonald @mphilbrick211