-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed tds width and margins issues #34687
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sundasnoreen12
force-pushed
the
sundas/INF-1371
branch
2 times, most recently
from
May 3, 2024 09:28
1db2581
to
e53de72
Compare
sundasnoreen12
requested review from
muhammadadeeltajamul,
ayesha-waris and
awais-ansari
May 3, 2024 09:44
awais-ansari
requested changes
May 3, 2024
openedx/core/djangoapps/notifications/templates/notifications/digest_header.html
Outdated
Show resolved
Hide resolved
sundasnoreen12
force-pushed
the
sundas/INF-1371
branch
2 times, most recently
from
May 7, 2024 07:43
6ae804a
to
f717292
Compare
sundasnoreen12
force-pushed
the
sundas/INF-1371
branch
from
May 8, 2024 07:05
f717292
to
6f9a340
Compare
awais-ansari
approved these changes
May 8, 2024
sundasnoreen12
force-pushed
the
sundas/INF-1371
branch
2 times, most recently
from
May 9, 2024 08:57
1d63b16
to
79b61bc
Compare
muhammadadeeltajamul
requested changes
May 9, 2024
openedx/core/djangoapps/notifications/templates/notifications/digest_header.html
Outdated
Show resolved
Hide resolved
sundasnoreen12
force-pushed
the
sundas/INF-1371
branch
from
May 10, 2024 08:03
c77154f
to
7789923
Compare
muhammadadeeltajamul
approved these changes
May 10, 2024
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INF-1371
Description
App titles needs to be text wrapped. When 5 or more titles are added, the UI gets messed up.
Solution
Added implementation to show 3 tds in a row and then remaining moves to next line.