Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Update tagged openassessment test #34782

Conversation

yusuf-musleh
Copy link
Member

Description

This updates the tests related to tagged openassessment blocks to avoid hardcoding the serialized olx that causes issues when attributes are added/removed down the road. See #34145 (comment)

Testing instructions

Make sure the tests pass.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 13, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @yusuf-musleh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@yusuf-musleh
Copy link
Member Author

@feanil Seems like one of the tests failed unexpectedly, just says that the job failed. Can you please rerun the remaining tests?

@yusuf-musleh yusuf-musleh force-pushed the yusuf-musleh/update-tagged-openassessment-test branch from 8764da5 to e8d07cf Compare May 14, 2024 07:37
@feanil feanil merged commit a6614ad into openedx:master May 14, 2024
79 checks passed
@openedx-webhooks
Copy link

@yusuf-musleh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants