feat: add register intent prop for login segment call #34891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahtesham-quraish
force-pushed
the
ahtesham/van-1929
branch
from
610344d to
437f4d4
Compare
| @@ -1041,6 +1041,7 @@ class LoginSessionViewTest(ApiTestCase, OpenEdxEventsTestMixin): | |||
| USERNAME = "bob" | |||
| EMAIL = "[email protected]" | |||
| PASSWORD = "password" | |||
| REGISTER_INTENT = True | |||
There was a problem hiding this comment.
its not some bool. please check it from request in tests as well as you are doing actually
There was a problem hiding this comment.
its changed
mubbsharanwar
requested changes
Jun 4, 2024
| @@ -360,7 +360,8 @@ def _track_user_login(user, request): | |||
| { | |||
| 'category': "conversion", | |||
| 'label': request.POST.get('course_id'), | |||
| 'provider': None | |||
| 'provider': None, | |||
| 'register_intent': bool(request.POST.get('register_intent')), | |||
There was a problem hiding this comment.
It would be always true if there would be any value in register_intent attribute.
Like:
bool('False')
--> True
There was a problem hiding this comment.
its changed
Description: Add register intent property for login successful segement call VAN-1929
ahtesham-quraish
force-pushed
the
ahtesham/van-1929
branch
from
437f4d4 to
e2981db
Compare
mubbsharanwar
approved these changes
Jun 4, 2024
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
syedsajjadkazmii
added a commit
that referenced
this pull request
Jun 21, 2024
This reverts commit a2aa6bd.
syedsajjadkazmii
added a commit
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add register intent property on login successful in segment call. The reason for adding this is to know how many users have landed on register page and then move to login page to get login.
Supporting information
Jira VAN-1929
Testing instructions
Unit test has been updated