feat: course outline page #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, @navinkarkera! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
openedx-webhooks
added
the
open-source-contribution
navinkarkera
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #694 +/- ##
==========================================
+ Coverage 88.65% 88.85% +0.20%
==========================================
Files 447 468 +21
Lines 6846 7168 +322
Branches 1461 1539 +78
==========================================
+ Hits 6069 6369 +300
- Misses 752 772 +20
- Partials 25 27 +2 ☔ View full report in Codecov by Sentry. |
Cup0fCoffee
reviewed
Nov 21, 2023
navinkarkera
force-pushed
the
navin/course-outline-mfe-page
branch
from
2f3b953 to
543b171
Compare
navinkarkera
force-pushed
the
navin/course-outline-mfe-page
branch
2 times, most recently
from
1fe7488 to
ded2c81
Compare
Cup0fCoffee
approved these changes
Nov 26, 2023
src/course-outline/header-navigations/HeaderNavigation.test.jsx
Outdated
Show resolved
Hide resolved
|
@Cup0fCoffee Thanks for the thorough review. Addressed all your comments. |
|
I've created issue TNL-11237 in the private 2U Jira. |
KristinAoki
requested changes
Nov 30, 2023
navinkarkera
force-pushed
the
navin/course-outline-mfe-page
branch
from
7ce8fa8 to
5ddb9bf
Compare
KristinAoki
approved these changes
Dec 5, 2023
* feat: [2u-259] add components * feat: [2u-259] fix sidebar * feat: [2u-259] add tests, fix links * feat: [2u-259] fix messages * feat: [2u-159] fix reducer and sidebar * feat: [2u-259] fix reducer * feat: [2u-259] remove warning from selectors * feat: [2u-259] remove indents --------- Co-authored-by: Vladislav Keblysh <[email protected]> feat: Course outline Status Bar (#50) * feat: [2u-259] add components * feat: [2u-259] fix sidebar * feat: [2u-259] add tests, fix links * feat: [2u-259] fix messages * feat: [2u-159] fix reducer and sidebar * feat: add checklist * feat: [2u-259] fix reducer * feat: [2u-259] remove warning from selectors * feat: [2u-259] remove indents * feat: [2u-259] add api, enable modal * feat: [2u-259] add tests * feat: [2u-259] add translates * feat: [2u-271] fix transalates * feat: [2u-281] fix isQuery pending, utils, hooks * feat: [2u-281] fix useScrollToHashElement * feat: [2u-271] fix imports --------- Co-authored-by: Vladislav Keblysh <[email protected]> feat: Course Outline Reindex (#55) * feat: [2u-277] add alerts * feat: [2u-277] add translates * feat: [2u-277] fix tests * fix: [2u-277] fix slice and hook --------- Co-authored-by: Vladislav Keblysh <[email protected]> fix: Course outline tests (#56) * fix: fixed course outline status bar tests * fix: fixed course outline status bar tests * fix: fixed course outline enable highlights modal tests * fix: enable modal tests fix: increase code coverage on the page
feat: lms live link chore: update outline link fix: course outline link refactor: remove unnecessary css and rename test file refactor: remove unnecessary css from outlineSidebar test: make use of message variable instead of hardcoded text refactor: remove unnecessary h5 class test: use test id for detecting component refactor: update course outline url and some default messages
navinkarkera
force-pushed
the
navin/course-outline-mfe-page
branch
from
2875840 to
80cc5e3
Compare
@KristinAoki Done. Also squashed commits, this is ready to be merged. |
|
@navinkarkera 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing work from #598
This PR adds
Screenshot:
Depends on: openedx/edx-platform#33667
Testing instructions: