fix: default context for painted door experiment #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brian-smith-tcril
requested review from
arbrandes,
httpsmenahassan,
cintnguyen and
muselesscreator
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #218 +/- ##
=======================================
Coverage 96.46% 96.46%
=======================================
Files 195 195
Lines 1839 1839
Branches 322 322
=======================================
Hits 1774 1774
Misses 60 60
Partials 5 5 ☔ View full report in Codecov by Sentry. |
cintnguyen
reviewed
Oct 16, 2023
src/widgets/RecommendationsPaintedDoorBtn/PaintedDoorExperimentContext.jsx
Outdated
Show resolved
Hide resolved
brian-smith-tcril
force-pushed
the
dont-use-env-var-to-paint-the-van
branch
from
aa34eee to
0a57d8d
Compare
arbrandes
added
the
needs maintainer attention
brian-smith-tcril
force-pushed
the
dont-use-env-var-to-paint-the-van
branch
from
0a57d8d to
b2f5a65
Compare
|
I'll be bringing this to our next team refinement session. |
brian-smith-tcril
force-pushed
the
dont-use-env-var-to-paint-the-van
branch
from
b2f5a65 to
98e0742
Compare
|
@justinhynes, any objections to this? |
|
Hey @arbrandes , since I'm on-call this week, I will approve this now that I understand that it wasn't meant to be merged alongside #214 ! |
jsnwesson
approved these changes
Nov 14, 2023
There are multiple places where attributes of the object provided by `usePaintedDoorExperimentContext()` are assumed to exist. This provides default (null) values for those attributes when creating the context.
|
@jsnwesson i just rebased this so it should be up to date now |
brian-smith-tcril
force-pushed
the
dont-use-env-var-to-paint-the-van
branch
from
98e0742 to
0cedeb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are multiple places where properties of the object provided by
usePaintedDoorExperimentContext()are assumed to exist. This provides default (null) values for those properties when creating the context.This PR is proposing a solution to #210 that would make it so #214 isn't needed.