-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: wrong text-color class and text contrast on dates page #1223
fix: wrong text-color class and text contrast on dates page #1223
Conversation
Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1223 +/- ##
=======================================
Coverage 88.19% 88.19%
=======================================
Files 271 271
Lines 4591 4591
Branches 1151 1151
=======================================
Hits 4049 4049
Misses 528 528
Partials 14 14 ☔ View full report in Codecov by Sentry. |
Hi @ihor-romaniuk, thank you for this contribution! I'm assuming that the changes are ready for review, but let me know if you were planning on working on them some more. -- @mattcarter This PR, as well as the corresponding backports to Palm (#1222) and Quince (#1229), are ready for Aurora to have a look. |
Hi @itsjeyd, this PR is ready for review, thanks. |
Hey @mattcarter, a friendly reminder to line this PR up for engineering review. Backports for Palm (#1222) and Quince (#1229) are ready to go as well. |
Hey @cmltaWt0, it looks like @ihor-romaniuk addressed your comments. Would you be able to have another look? Also I was wondering if you're in a position to provide final approval for this PR? I'm asking because based on info from the Core Contributors to the Open edX Project page seems like you're not a "regular" CC for the parent repo:
... And I'm not sure if reviewing and merging this PR falls under release management, if that makes sense? Let me know what you think, it's completely possible that I'm missing something :) |
Calling all CCs for frontend-app-learning: @brian-smith-tcril Would you have bandwidth for reviewing and merging this PR? (Even if you don't, it would be great if you could comment below and state that. Otherwise it's hard to know if there's a need to keep looking for reviewers. Thanks for your help!) |
@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description:
This pull request contains minor fixes with text colors.
text-color
class on dates pageRelated Pull Requests
PR to the open-release/palm.master branch: #1222
PR to the open-release/quince.master branch: #1229