Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: container width and responsive for navigation block #1219

Conversation

ihor-romaniuk
Copy link
Contributor

@ihor-romaniuk ihor-romaniuk commented Oct 25, 2023

Description:

This pull request contains minor fixes related to responsiveness and block rebuilding.

  • Fixed container width on mobile devices
Before After
image image
  • Fixed adaptation of controls and navigation
Before (500px) Before (375px)
image image
After (700px) After (600px) After (500px) After (375px)
image image image image

Related Pull Requests

PR to the open-release/palm.master branch: #1218
PR to the open-release/quince.master branch: #1227

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 25, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 25, 2023

Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4928f50) 88.29% compared to head (18cf028) 88.30%.
Report is 7 commits behind head on master.

Files Patch % Lines
src/courseware/course/sequence/Sequence.jsx 91.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1219   +/-   ##
=======================================
  Coverage   88.29%   88.30%           
=======================================
  Files         291      291           
  Lines        4923     4924    +1     
  Branches     1239     1239           
=======================================
+ Hits         4347     4348    +1     
  Misses        562      562           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@itsjeyd
Copy link

itsjeyd commented Nov 2, 2023

Hi @ihor-romaniuk, thank you for this contribution!

I'm assuming that the changes are ready for review, but let me know if you were planning on working on them some more.

--

@mattcarter This PR, as well as the corresponding backports to Palm (#1218) and Quince (#1227), are ready for Aurora to have a look.

@itsjeyd itsjeyd added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Nov 2, 2023
@ihor-romaniuk
Copy link
Contributor Author

Hi @itsjeyd, this PR is ready for review, thanks.

@itsjeyd
Copy link

itsjeyd commented Nov 17, 2023

Hey @mattcarter, a friendly reminder to line this PR up for engineering review. Backports for Palm (#1218) and Quince (#1227) are ready to go as well.

@itsjeyd
Copy link

itsjeyd commented Nov 29, 2023

@ihor-romaniuk Just to keep you in the loop, we're still working on getting this PR unblocked. The same goes for the other PRs that you opened in this repo (#1220 and Palm/Quince backports, #1223 and Palm/Quince backports).

CC @mphilbrick211

@xitij2000
Copy link
Contributor

@ihor-romaniuk I see that I was tagged as reviewer here. I am not a core committer for this repo. So while I can help review I cannot get this merged.

@BilalQamar95 BilalQamar95 removed their request for review December 4, 2023 13:45
@cmltaWt0 cmltaWt0 added the product review PR requires product review before merging label Feb 8, 2024
@itsjeyd
Copy link

itsjeyd commented Mar 11, 2024

This is just a small fix and I doubt that it needs to go through the full product review cycle. (That's why I didn't add the product review label when I first triaged the changes.) Removing product review label now.

@itsjeyd itsjeyd removed the product review PR requires product review before merging label Mar 11, 2024
@itsjeyd
Copy link

itsjeyd commented Mar 11, 2024

Calling all CCs for frontend-app-learning:

@brian-smith-tcril
@arbrandes
@viktorrusakov
@BbrSofiane

Would you have bandwidth for reviewing and merging this PR?

(Even if you don't, it would be great if you could comment below and state that. Otherwise it's hard to know if there's a need to keep looking for reviewers. Thanks for your help!)

@arbrandes arbrandes requested review from arbrandes and removed request for xitij2000 March 13, 2024 16:14
Copy link

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this and, indeed, it looks much better for small screens! No ill effects on large ones, either. Approved, and thanks!

@arbrandes arbrandes merged commit 92d8f63 into openedx:master Mar 13, 2024
6 checks passed
@openedx-webhooks
Copy link

@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@itsjeyd itsjeyd removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants