-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: container width and responsive for navigation block #1219
fix: container width and responsive for navigation block #1219
Conversation
Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1219 +/- ##
=======================================
Coverage 88.29% 88.30%
=======================================
Files 291 291
Lines 4923 4924 +1
Branches 1239 1239
=======================================
+ Hits 4347 4348 +1
Misses 562 562
Partials 14 14 ☔ View full report in Codecov by Sentry. |
Hi @ihor-romaniuk, thank you for this contribution! I'm assuming that the changes are ready for review, but let me know if you were planning on working on them some more. -- @mattcarter This PR, as well as the corresponding backports to Palm (#1218) and Quince (#1227), are ready for Aurora to have a look. |
Hi @itsjeyd, this PR is ready for review, thanks. |
Hey @mattcarter, a friendly reminder to line this PR up for engineering review. Backports for Palm (#1218) and Quince (#1227) are ready to go as well. |
@ihor-romaniuk Just to keep you in the loop, we're still working on getting this PR unblocked. The same goes for the other PRs that you opened in this repo (#1220 and Palm/Quince backports, #1223 and Palm/Quince backports). |
@ihor-romaniuk I see that I was tagged as reviewer here. I am not a core committer for this repo. So while I can help review I cannot get this merged. |
This is just a small fix and I doubt that it needs to go through the full product review cycle. (That's why I didn't add the |
Calling all CCs for frontend-app-learning: @brian-smith-tcril Would you have bandwidth for reviewing and merging this PR? (Even if you don't, it would be great if you could comment below and state that. Otherwise it's hard to know if there's a need to keep looking for reviewers. Thanks for your help!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this and, indeed, it looks much better for small screens! No ill effects on large ones, either. Approved, and thanks!
@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description:
This pull request contains minor fixes related to responsiveness and block rebuilding.
Related Pull Requests
PR to the open-release/palm.master branch: #1218
PR to the open-release/quince.master branch: #1227