Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong text-color class and text contrast on dates page #1223

Conversation

ihor-romaniuk
Copy link
Contributor

@ihor-romaniuk ihor-romaniuk commented Oct 25, 2023

Description:

This pull request contains minor fixes with text colors.

  • Fixed wrong text-color class on dates page
  • Increase text color contrast on dates page
Before After
image image

Related Pull Requests

PR to the open-release/palm.master branch: #1222
PR to the open-release/quince.master branch: #1229

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 25, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 25, 2023

Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7c92110) 88.19% compared to head (7e8340c) 88.19%.
Report is 40 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1223   +/-   ##
=======================================
  Coverage   88.19%   88.19%           
=======================================
  Files         271      271           
  Lines        4591     4591           
  Branches     1151     1151           
=======================================
  Hits         4049     4049           
  Misses        528      528           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@itsjeyd
Copy link

itsjeyd commented Nov 2, 2023

Hi @ihor-romaniuk, thank you for this contribution!

I'm assuming that the changes are ready for review, but let me know if you were planning on working on them some more.

--

@mattcarter This PR, as well as the corresponding backports to Palm (#1222) and Quince (#1229), are ready for Aurora to have a look.

@itsjeyd itsjeyd added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Nov 2, 2023
@ihor-romaniuk
Copy link
Contributor Author

Hi @itsjeyd, this PR is ready for review, thanks.

@itsjeyd
Copy link

itsjeyd commented Nov 17, 2023

Hey @mattcarter, a friendly reminder to line this PR up for engineering review. Backports for Palm (#1222) and Quince (#1229) are ready to go as well.

@itsjeyd itsjeyd requested a review from mattcarter December 7, 2023 13:39
@itsjeyd itsjeyd removed the request for review from mattcarter February 2, 2024 14:56
@cmltaWt0 cmltaWt0 added product review PR requires product review before merging and removed product review PR requires product review before merging labels Feb 8, 2024
@itsjeyd itsjeyd requested a review from cmltaWt0 February 16, 2024 10:42
@itsjeyd
Copy link

itsjeyd commented Feb 22, 2024

Hey @cmltaWt0, it looks like @ihor-romaniuk addressed your comments. Would you be able to have another look?

Also I was wondering if you're in a position to provide final approval for this PR?

I'm asking because based on info from the Core Contributors to the Open edX Project page seems like you're not a "regular" CC for the parent repo:

Merge rights for all release branches

Write access to edx-app-test, devstack, edx-e2e-tests, cypress-e2e-tests, edx-app-test

For release management: write access to all repos currently in the latest named release (via community-release-managers group).

... And I'm not sure if reviewing and merging this PR falls under release management, if that makes sense?

Let me know what you think, it's completely possible that I'm missing something :)

@itsjeyd
Copy link

itsjeyd commented Mar 11, 2024

Calling all CCs for frontend-app-learning:

@brian-smith-tcril
@arbrandes
@viktorrusakov
@BbrSofiane

Would you have bandwidth for reviewing and merging this PR?

(Even if you don't, it would be great if you could comment below and state that. Otherwise it's hard to know if there's a need to keep looking for reviewers. Thanks for your help!)

@brian-smith-tcril brian-smith-tcril merged commit b715959 into openedx:master Mar 11, 2024
5 checks passed
@openedx-webhooks
Copy link

@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@itsjeyd itsjeyd removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants