-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: wrong text-color class and text contrast on dates page #1229
fix: wrong text-color class and text contrast on dates page #1229
Conversation
Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## open-release/quince.master #1229 +/- ##
=============================================================
Coverage ? 88.04%
=============================================================
Files ? 266
Lines ? 4518
Branches ? 1142
=============================================================
Hits ? 3978
Misses ? 526
Partials ? 14 ☔ View full report in Codecov by Sentry. |
Hi @ihor-romaniuk, thank you for this contribution! I'm assuming that the changes are ready for review, but let me know if you were planning on working on them some more. |
Hi @itsjeyd, this PR is ready for review, thanks. |
@brian-smith-tcril Thanks for merging the main PR (#1223) for this change! Could you do the same for the Palm and Quince backports (#1222 and this PR)? If you don't have time/bandwidth, I can ask someone else; just let me know. |
887335f
into
openedx:open-release/quince.master
@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description:
This pull request contains minor fixes with text colors.
text-color
class on dates pageRelated Pull Requests
PR to the open-release/palm.master branch: #1222
PR to the master branch: #1223