-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: container width and responsive for navigation block #1227
fix: container width and responsive for navigation block #1227
Conversation
Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## open-release/quince.master #1227 +/- ##
=============================================================
Coverage ? 88.05%
=============================================================
Files ? 266
Lines ? 4519
Branches ? 1142
=============================================================
Hits ? 3979
Misses ? 526
Partials ? 14 ☔ View full report in Codecov by Sentry. |
Hi @ihor-romaniuk, thank you for this contribution! I'm assuming that the changes are ready for review, but let me know if you were planning on working on them some more. |
Hi @itsjeyd, this PR is ready for review, thanks. |
Hey @cmltaWt0, I see that you added the product review label here. Was there a specific reason for doing so? I'm asking because this is a backport PR, and we usually only add the product review label to PRs targeting Same question for #1228 and #1229, which are also backports. |
Hey @itsjeyd. It was done intentionally to be able to create a filtering to share PRs related to |
@itsjeyd I've moved |
@cmltaWt0 Got it, thanks for the details ☑️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Master PR got merged, time to merge this one too!
c8ab163
into
openedx:open-release/quince.master
@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description:
This pull request contains minor fixes related to responsiveness and block rebuilding.
Related Pull Requests
PR to the open-release/palm.master branch: #1218
PR to the master branch: #1219