Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: container width and responsive for navigation block #1227

Conversation

ihor-romaniuk
Copy link
Contributor

Description:

This pull request contains minor fixes related to responsiveness and block rebuilding.

  • Fixed container width on mobile devices
Before After
image image
  • Fixed adaptation of controls and navigation
Before (500px) Before (375px)
image image
After (700px) After (600px) After (500px) After (375px)
image image image image

Related Pull Requests

PR to the open-release/palm.master branch: #1218
PR to the master branch: #1219

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 27, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 27, 2023

Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (open-release/quince.master@b24568f). Click here to learn what that means.

Additional details and impacted files
@@                      Coverage Diff                      @@
##             open-release/quince.master    #1227   +/-   ##
=============================================================
  Coverage                              ?   88.05%           
=============================================================
  Files                                 ?      266           
  Lines                                 ?     4519           
  Branches                              ?     1142           
=============================================================
  Hits                                  ?     3979           
  Misses                                ?      526           
  Partials                              ?       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@itsjeyd
Copy link

itsjeyd commented Nov 2, 2023

Hi @ihor-romaniuk, thank you for this contribution!

I'm assuming that the changes are ready for review, but let me know if you were planning on working on them some more.

@itsjeyd itsjeyd added waiting for eng review PR is ready for review. Review and merge it, or suggest changes. backport PR backports a change from main to a named release. labels Nov 2, 2023
@ihor-romaniuk
Copy link
Contributor Author

Hi @itsjeyd, this PR is ready for review, thanks.

@cmltaWt0 cmltaWt0 added the product review PR requires product review before merging label Feb 6, 2024
@itsjeyd
Copy link

itsjeyd commented Feb 8, 2024

Hey @cmltaWt0, I see that you added the product review label here. Was there a specific reason for doing so? I'm asking because this is a backport PR, and we usually only add the product review label to PRs targeting master. (Reason being that if a PR passes product review on master, there is no need for product to look at corresponding backports.)

Same question for #1228 and #1229, which are also backports.

CC @mphilbrick211

@cmltaWt0
Copy link

cmltaWt0 commented Feb 8, 2024

Hey @cmltaWt0, I see that you added the product review label here. Was there a specific reason for doing so? I'm asking because this is a backport PR, and we usually only add the product review label to PRs targeting master. (Reason being that if a PR passes product review on master, there is no need for product to look at corresponding backports.)

Same question for #1228 and #1229, which are also backports.

CC @mphilbrick211

Hey @itsjeyd. It was done intentionally to be able to create a filtering to share PRs related to end user experience and are important for Quince release.
I understand that this is a bit against the flow but I have to do it as a first quick step.
I can move product review tags to attached master PRs now. Just want to ensure these PRs won't be lost.

@cmltaWt0 cmltaWt0 removed the product review PR requires product review before merging label Feb 8, 2024
@cmltaWt0
Copy link

cmltaWt0 commented Feb 8, 2024

@itsjeyd I've moved product review tag to master PRs.

@itsjeyd
Copy link

itsjeyd commented Feb 16, 2024

@cmltaWt0 Got it, thanks for the details ☑️

Copy link

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Master PR got merged, time to merge this one too!

@arbrandes arbrandes merged commit c8ab163 into openedx:open-release/quince.master Mar 13, 2024
5 checks passed
@openedx-webhooks
Copy link

@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@itsjeyd itsjeyd removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants