-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testiing Reduce css #1047
Testiing Reduce css #1047
Conversation
Thanks for the pull request, @ghassanmas! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate. |
@ghassanmas this is interesting work. Should this be a draft PR? It's helpful for us that PRs remain in a draft state until they are ready for review. |
@e0d initially I opened this PR to ease the testing of openedx/frontend-build#266 |
label: core contributor |
Hey @ghassanmas, now that openedx/frontend-build#266 has been merged (🎉), will you be picking up work on this PR again? |
@ghassanmas A friendly ping about my previous comment. |
@itsjeyd Sorry for the late reply. And thank you for the reminder. I can open a new PR to upgrade it but I suspect it will be relate to this PR #1084. So it's best in terms of reducing friction, merge conflict...etc That if #1084 would also update front-build to at least 12.8.0, given from version > 12.7.0 ref frontend-build is upgraded to use node 18. Also that PR is already tracked to be included in Palm in openedx/wg-build-test-release/issues/261. Moving forward, I will close this PR, and I will comment on the referred PR #1084 to ask if it's possible to upgrade frontend-build, I will also check frontend-build version for other MFEs to ensure this feature is available for palm. |
@ghassanmas Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
No worries, and thanks for the detailed update @ghassanmas! :) |
This is opened only for testing purpose regarding openedx/frontend-build/pull/266