feat: upgraded to node v18, added .nvmrc and updated workflows #1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into bilalqamar95/node-v18-upgrade
…lalqamar95/node-v18-upgrade
…lalqamar95/node-v18-upgrade
…x/frontend-app-learning into bilalqamar95/node-v18-upgrade
…lalqamar95/node-v18-upgrade
This was referenced Apr 13, 2023
Closed
|
Hello, Would it be possible to upgrade frontend-build in this PR to at least 12.8.0 (similar to this openedx/frontend-app-authoring/pull/464 ) hence from 12.7.0 frontend-build is upgraded to use node 18. I just think doing it through this PR would be more efficient and I am happy to help if there are any blockers to this PR. For more context: #1047 (comment) CC: @itsjeyd |
…nto bilalqamar95/node-v18-upgrade
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1084 +/- ##
==========================================
- Coverage 87.01% 86.96% -0.05%
==========================================
Files 253 253
Lines 4382 4382
Branches 1108 1108
==========================================
- Hits 3813 3811 -2
- Misses 550 552 +2
Partials 19 19 ☔ View full report in Codecov by Sentry. |
|
Hey, just a note about frontend-build in the comment above, would that befeasible to do this PR?
…On Tue, May 9, 2023, 8:09 PM Jansen Kantor ***@***.***> wrote:
***@***.**** approved this pull request.
Makes sense to me
—
Reply to this email directly, view it on GitHub
<#1084 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD42PH3BEZZBYF6WYF7HOBLXFJ24NANCNFSM6AAAAAAV3OTERU>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
…nto bilalqamar95/node-v18-upgrade
Sure @ghassanmas, I have updated |
…lqamar95/node-v18-upgrade
|
I temporarily removed |
…lalqamar95/node-v18-upgrade
|
Tests re-enabled. |
Mashal-m
pushed a commit
that referenced
this pull request
May 31, 2023
* feat: upgraded to node v18, added .nvmrc and updated workflows * refactor: updated packages * refactor: updated packages * refactor: updated packages * fix: add workaround in json file * build: remove jestEnv line from json * refactor: updated packages * refactor: updated packages * refactor: updated packages * refactor: updated packages * refactor: updated packages * refactor: updated packages * fix: add workaround in json file * build: remove jestEnv line from json * refactor: updated packages * refactor: updated packages * refactor: updated packages * refactor: updated packages * refactor: updated packages * refactor: updated jest & fixed failing tests * refactor: updated lmsPact failing test cases * refactor: updated frontend-build version * Merge branch master of github.com:edx/frontend-app-learning into bilalqamar95/node-v18-upgrade --------- Co-authored-by: mashal-m <[email protected]>
mtyaka
pushed a commit
that referenced
this pull request
Jun 9, 2023
* feat: upgraded to node v18, added .nvmrc and updated workflows * refactor: updated packages * refactor: updated packages * refactor: updated packages * fix: add workaround in json file * build: remove jestEnv line from json * refactor: updated packages * refactor: updated packages * refactor: updated packages * refactor: updated packages * refactor: updated packages * refactor: updated packages * fix: add workaround in json file * build: remove jestEnv line from json * refactor: updated packages * refactor: updated packages * refactor: updated packages * refactor: updated packages * refactor: updated packages * refactor: updated jest & fixed failing tests * refactor: updated lmsPact failing test cases * refactor: updated frontend-build version * Merge branch master of github.com:edx/frontend-app-learning into bilalqamar95/node-v18-upgrade --------- Co-authored-by: mashal-m <[email protected]>
bra-i-am
pushed a commit
to eduNEXT/frontend-app-learning
that referenced
this pull request
Nov 9, 2023
…dx#1084) * feat: upgraded to node v18, added .nvmrc and updated workflows * refactor: updated packages * refactor: updated packages * refactor: updated packages * fix: add workaround in json file * build: remove jestEnv line from json * refactor: updated packages * refactor: updated packages * refactor: updated packages * refactor: updated packages * refactor: updated packages * refactor: updated packages * fix: add workaround in json file * build: remove jestEnv line from json * refactor: updated packages * refactor: updated packages * refactor: updated packages * refactor: updated packages * refactor: updated packages * refactor: updated jest & fixed failing tests * refactor: updated lmsPact failing test cases * refactor: updated frontend-build version * Merge branch master of github.com:edx/frontend-app-learning into bilalqamar95/node-v18-upgrade --------- Co-authored-by: mashal-m <[email protected]>
bra-i-am
pushed a commit
to eduNEXT/frontend-app-learning
that referenced
this pull request
Nov 9, 2023
…dx#1084) * feat: upgraded to node v18, added .nvmrc and updated workflows * refactor: updated packages * refactor: updated packages * refactor: updated packages * fix: add workaround in json file * build: remove jestEnv line from json * refactor: updated packages * refactor: updated packages * refactor: updated packages * refactor: updated packages * refactor: updated packages * refactor: updated packages * fix: add workaround in json file * build: remove jestEnv line from json * refactor: updated packages * refactor: updated packages * refactor: updated packages * refactor: updated packages * refactor: updated packages * refactor: updated jest & fixed failing tests * refactor: updated lmsPact failing test cases * refactor: updated frontend-build version * Merge branch master of github.com:edx/frontend-app-learning into bilalqamar95/node-v18-upgrade --------- Co-authored-by: mashal-m <[email protected]>
moonesque
pushed a commit
to edSPIRIT/frontend-app-learning
that referenced
this pull request
Nov 11, 2023
…dx#1084) * feat: upgraded to node v18, added .nvmrc and updated workflows * refactor: updated packages * refactor: updated packages * refactor: updated packages * fix: add workaround in json file * build: remove jestEnv line from json * refactor: updated packages * refactor: updated packages * refactor: updated packages * refactor: updated packages * refactor: updated packages * refactor: updated packages * fix: add workaround in json file * build: remove jestEnv line from json * refactor: updated packages * refactor: updated packages * refactor: updated packages * refactor: updated packages * refactor: updated packages * refactor: updated jest & fixed failing tests * refactor: updated lmsPact failing test cases * refactor: updated frontend-build version * Merge branch master of github.com:edx/frontend-app-learning into bilalqamar95/node-v18-upgrade --------- Co-authored-by: mashal-m <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Upgrade Node Js from 16 to 18
Description
frontend-buildto v12.8edx-internal PR
https://github.com/edx/edx-internal/pull/8336
This needs to be merged together.