Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make notification display by default #1234

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

leangseu-edx
Copy link
Contributor

Make some change to have notification correctly.

The bug was introduced on this pr #1139

Copy link
Contributor

@mattcarter mattcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but you need to fix the spaces causing the test failure.

@leangseu-edx leangseu-edx force-pushed the lk/make-notification-default-open branch from 91cb1f5 to 1a1b4a6 Compare November 9, 2023 15:14
@leangseu-edx leangseu-edx merged commit c38d69f into master Nov 9, 2023
3 checks passed
@leangseu-edx leangseu-edx deleted the lk/make-notification-default-open branch November 9, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants